Refactor encryption #23
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor to use futures channels bc they implement Sender
fixes the issue of the messages not being sent
more tests better logs
cowlicks
commented
May 20, 2025
| /// TODO Poll the keepalive timer and queue a ping message if needed. | ||
| fn poll_keepalive(&mut self, _cx: &mut Context<'_>) { | ||
| /* | ||
| const KEEPALIVE_DURATION: Duration = Duration::from_secs(DEFAULT_KEEPALIVE as u64); |
cowlicks
commented
May 20, 2025
| @@ -1,7 +1,11 @@ | |||
| use hypercore::encoding::{CompactEncoding, EncodingError, HypercoreState, State}; | |||
| use compact_encoding::{ | |||
There was a problem hiding this comment.
Write a macro to shorten the ComppactEncoding impls
ran: cargo +nightly fmt with: imports_granularity = "crate" in .rustformat.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.