Fix TypeError when get_line_code called on literals - #2104
Open
clayote wants to merge 2 commits into
Open
Conversation
Calling this method on literals usually takes you to standard library code, tightly wrapping the underlying C. Not very useful most of the time, but a logical thing to ask for. Jedi should have the ability.
Owner
|
But the question here is: Why does this happen? This might just be a bug in a different place. Catching AttributeErrors like this is almost always a bad idea unless we actually know what's going on and then a comment should probably describe that. |
Owner
|
Also you are changing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling this method on literals usually takes you to standard library code, tightly wrapping the underlying C. Not very useful most of the time, but a logical thing to ask for.
Jedi should have the ability.
The lack of it caused an error in emacs' anaconda-mode when attempting to inspect the name of a literal value.