Feature/ds card component #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoecher
reviewed
Nov 14, 2024
Comment on lines
20
to
21
| // The card components are shaded and rounded areas that give the interface depth. | ||
| // Whether static or interactive - the cards are the basis for further components and modules and can display content and actions. |
There was a problem hiding this comment.
Change the comment lines to KDoc and add missing parameter with descriptions.
Comment on lines
29
to
39
| val spacingValue = when (spacing) { | ||
| DSSpacing.SMALL -> DesignSystemTheme.dimensions.spacing.fixedSm | ||
| DSSpacing.MEDIUM -> DesignSystemTheme.dimensions.spacing.fixedMd | ||
| DSSpacing.LARGE -> DesignSystemTheme.dimensions.spacing.fixedLg | ||
| } | ||
|
|
||
| val elevationColor = when (elevation) { | ||
| DSCardElevation.LEVEL_1 -> DesignSystemTheme.activeColor.bgBasicLevel1Default | ||
| DSCardElevation.LEVEL_2 -> DesignSystemTheme.activeColor.bgBasicLevel2Default | ||
| DSCardElevation.LEVEL_3 -> DesignSystemTheme.activeColor.bgBasicLevel3Default | ||
| } |
There was a problem hiding this comment.
Add these values to the respective enum as attributes.
| } | ||
| } | ||
|
|
||
| enum class DSSpacing { SMALL, MEDIUM, LARGE } |
| .padding(spacingValue) | ||
| .then(modifier) | ||
| ) { | ||
| Column(modifier = Modifier, content = content) |
There was a problem hiding this comment.
Should we use Modifier.fillMaxSize()? Or even better: Use the content parameter directly for the surfaces' content attribute.
|
|
||
| @Composable | ||
| @Preview() | ||
| fun DSCardPreview() { |
There was a problem hiding this comment.
Add DSCardElevation and DSCardSpacing PreviewParameters and use them for the preview. Maybe we could also add a PreviewParameter with some colors to preview adaptive colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.