-
Notifications
You must be signed in to change notification settings - Fork 13
fix(DBCustomSelect): form reset functionality #4853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
32
commits into
main
Choose a base branch
from
copilot/fix-4724
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
60de8b1
Initial plan
Copilot ad57a0b
Initial analysis of DBCustomSelect form reset issue
Copilot 65f7a3b
Implement form reset handling for DBCustomSelect
Copilot e7d5d09
Successful test validation of DBCustomSelect form reset fix
Copilot 54b317a
Merge branch 'main' into copilot/fix-4724
mfranzke a447b50
Merge branch 'main' into copilot/fix-4724
mfranzke d89a1dc
Merge remote-tracking branch 'refs/remotes/origin/main' into copilot/…
nmerget 2fd9b3a
feat: add form reset for every form component
nmerget b7eac5c
fix: linting issues
nmerget 2e2113b
refactor: formatting
mfranzke fc8bc74
fix: linting issues
nmerget 03315e4
Merge remote-tracking branch 'origin/copilot/fix-4724' into copilot/f…
nmerget 4c97b02
Merge branch 'main' into copilot/fix-4724
nmerget 61a7598
Merge branch 'main' into copilot/fix-4724
mfranzke f960b05
fix: typescript issue
nmerget 1873988
Merge branch 'main' into copilot/fix-4724
nmerget 714b2e3
chore: add changeset
nmerget 2a61cb4
fix: issue with react showcase
nmerget 91f82d6
Merge branch 'main' into copilot/fix-4724
nmerget c1ffca3
auto update snapshots (#5082)
github-actions[bot] aba2e6b
fix: issue with showcase-home.spec.ts
nmerget a34412a
Merge branch 'main' into copilot/fix-4724
nmerget e6b5701
Merge branch 'main' into copilot/fix-4724
mfranzke 60530f9
Merge branch 'main' into copilot/fix-4724
mfranzke f046112
auto update snapshots (#5145)
github-actions[bot] 9d90943
Merge branch 'main' into copilot/fix-4724
mfranzke 80bc04a
auto update snapshots (#5146)
github-actions[bot] 7b610f8
chore: update from main
nmerget 5bb09ba
auto update snapshots (#5173)
github-actions[bot] 3970c78
fix: issues with onChange handler for angular
nmerget 83466ad
Merge branch 'main' into copilot/fix-4724
nmerget 99ea02f
fix: linting issues
nmerget File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
"@db-ux/core-components": patch | ||
"@db-ux/ngx-core-components": patch | ||
"@db-ux/react-core-components": patch | ||
"@db-ux/v-core-components": patch | ||
"@db-ux/wc-core-components": patch | ||
--- | ||
|
||
fix(DBCustomSelect): automatically handle form reset events | ||
|
||
An event listener is now added for every form component (input, custom-select, etc.) when a `form` property is passed. | ||
This listener detects form resets and updates the component's internal value/checked state accordingly. | ||
|
||
nmerget marked this conversation as resolved.
Show resolved
Hide resolved
|
||
> **Note**: This does not work for `ngModel` in Angular. |
Binary file modified
BIN
-2.84 KB
(91%)
__snapshots__/radio/patternhub/radio-properties-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-50 Bytes
(100%)
__snapshots__/switch/patternhub/switch-properties-should-match-screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.