Skip to content

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Oct 6, 2025

Proposed changes

This reverts commit b81f49d.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Oct 6, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Oct 6, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in UX Engineering Team Backlog Oct 6, 2025
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: 2518446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 6, 2025

.npmrc Outdated
# If set to false, then ignore package-lock.json files when installing. This will also prevent writing package-lock.json if save is true. source: https://docs.npmjs.com/cli/v11/using-npm/config
package-lock=true
# If true, npm does not run scripts specified in package.json files. source: https://docs.npmjs.com/cli/v11/using-npm/config#ignore-scripts
ignore-scripts=true
Copy link
Collaborator Author

@mfranzke mfranzke Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ignore-scripts=true
ignore-scripts=true

This setting also appears to prevent our pre- and post-scripts from running in our repository workspaces.

@mfranzke
Copy link
Collaborator Author

mfranzke commented Oct 6, 2025

we should merge #4631 previous to this PR, as pnpm seems to allowed our own pre- and post-Node-scripts to still run even though that we set ignore-scripts to true (which is pnpms default setting anyhow).

@mfranzke mfranzke marked this pull request as draft October 7, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍄🆙improvement New feature or request

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

1 participant