Feat/dbeaver/vscode#86/storybook integration #3251
Conversation
SychevAndrey
force-pushed
the
feat/dbeaver/vscode#86/storybook-integration
branch
2 times, most recently
from
aeaf44d to
60369a4
Compare
… values as default
…tead of many stories
SychevAndrey
force-pushed
the
feat/dbeaver/vscode#86/storybook-integration
branch
from
bbfb88d to
574f786
Compare
….com:dbeaver/cloudbeaver into feat/dbeaver/vscode#86/storybook-integration
|
We need to use prefixes because we have different products and already have prefixes in the vs. code, so we can easily navigate to the correct part of the codebase; it's the same reason I suggested adding prefixes for class names. We can have multiple controls in our codebase (like one from UI Kit, and we may have one in each product as well) |
| "scripts": { | ||
| "build": "tsc -b", | ||
| "clean": "rimraf --glob dist", | ||
| "lint": "eslint ./src/ --ext .ts,.tsx" |
There was a problem hiding this comment.
removed lint command for now. By the way, all our packages use exact same lint command, should we create a ticket to refactor it?
| --btn-border-width: 1px; | ||
| --btn-border-color: transparent; | ||
| --btn-border-style: solid; | ||
| --btn-radius: var(--radius-md); |
There was a problem hiding this comment.
i think we need some base variables on the theme layout for global things like:
- controls radius - it may be used for buttons, inputs, text areas (examples)
- maybe padding (like spacing between elements)
There was a problem hiding this comment.
I added vars for border, but I'm not sure about spacing right now. First of all, we can use tailwind directly, they have spacing units like p(padding) and m(margin) based on rem, they have container units like w- and h- based on rem.
Plus, creating the layout and grid units is more about product, not the UI-kit itself until it's very opinionated and have to be used as is which is not true in our case. We can create components / recommendation/ guidelines of how to use spacing in the product.
….com:dbeaver/cloudbeaver into feat/dbeaver/vscode#86/storybook-integration
…use it's strange that button reacts on click when in loading state, but not on hover.
| .p { | ||
| p { |
There was a problem hiding this comment.
why has class now changed to a global style? this is CSS module we should not use global selectors like that
No description provided.