Skip to content

Conversation

@MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Dec 1, 2025

Problem

jsonschema-based deprecations were being rolled out slowly behind the DBT_ENV_PRIVATE_RUN_JSONSCHEMA_VALIDATIONS as the jsonschema process + schemas themselves were being tightened up. We're in a good place to have these fire by default now for the 1.11.0 release!

Solution

Remove DBT_ENV_PRIVATE_RUN_JSONSCHEMA_VALIDATIONSgating
docs: dbt-labs/docs.getdbt.com#8237

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Dec 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.98%. Comparing base (1219bd4) to head (df1511d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12240      +/-   ##
==========================================
- Coverage   92.00%   91.98%   -0.03%     
==========================================
  Files         203      203              
  Lines       24965    24962       -3     
==========================================
- Hits        22970    22961       -9     
- Misses       1995     2001       +6     
Flag Coverage Δ
integration 88.87% <ø> (-0.10%) ⬇️
unit 65.28% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.28% <ø> (+0.09%) ⬆️
Integration Tests 88.87% <ø> (-0.10%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MichelleArk MichelleArk force-pushed the jsonschema-deprecations-default-true branch from 38a155b to b9109d6 Compare December 1, 2025 19:42
@MichelleArk MichelleArk changed the title first pass: turn on jsonschema deprecations by default turn on jsonschema-based deprecations by default Dec 1, 2025
@MichelleArk MichelleArk changed the title turn on jsonschema-based deprecations by default Tturn on jsonschema-based deprecations by default Dec 1, 2025
@MichelleArk MichelleArk changed the title Tturn on jsonschema-based deprecations by default Turn on jsonschema-based deprecations by default, based on adapter support Dec 1, 2025
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@MichelleArk MichelleArk merged commit 5d56a05 into main Dec 2, 2025
60 of 61 checks passed
@MichelleArk MichelleArk deleted the jsonschema-deprecations-default-true branch December 2, 2025 17:37
github-actions bot pushed a commit that referenced this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants