-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Turn on jsonschema-based deprecations by default, based on adapter support #12240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12240 +/- ##
==========================================
- Coverage 92.00% 91.98% -0.03%
==========================================
Files 203 203
Lines 24965 24962 -3
==========================================
- Hits 22970 22961 -9
- Misses 1995 2001 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
38a155b to
b9109d6
Compare
QMalcolm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go go go
Problem
jsonschema-based deprecations were being rolled out slowly behind the
DBT_ENV_PRIVATE_RUN_JSONSCHEMA_VALIDATIONSas the jsonschema process + schemas themselves were being tightened up. We're in a good place to have these fire by default now for the 1.11.0 release!Solution
Remove
DBT_ENV_PRIVATE_RUN_JSONSCHEMA_VALIDATIONSgatingdocs: dbt-labs/docs.getdbt.com#8237
Checklist