fix: node.js auto-configuration not supporting multiple projects #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkibaAT
added
bug
AkibaAT
force-pushed
the
bug/nodejs-autoconfigure
branch
from
13d102a to
27b2017
Compare
|
|
Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Currently, the Node.js auto-configuration does nothing if it finds at least one configured interpreter. Additionally, it doesn't ensure that the available interpreters include one for the current DDEV project.
How this PR Solves the Problem:
Update the check to iterate over the available configurations, and verify that they include the expected docker-compose config for the current project.
Manual Testing Instructions:
Related Issue Link(s):