ci: stop updating .pot file, rely on Weblate doing it#2078
Open
amezin wants to merge 1 commit into
Open
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull-request composite action was removed. Translation generation headers and Meson gettext configuration were simplified, and CI now performs separate checks for POTFILES and translation files while ignoring volatile headers. ChangesTranslation pipeline
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
amezin
marked this pull request as ready for review
July 22, 2026 05:08
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 423-430: Update the “Diff translations” workflow step to remove
the po/*.pot pathspec, leaving the git diff check scoped only to po/*.po.
Preserve the existing ignored translation metadata lines and all other CI
behavior.
- Around line 423-430: Update the “Diff translations” workflow step to pass
--exit-code to git diff, ensuring differences in po/*.po or po/*.pot cause the
CI step to fail while preserving the existing ignored-line filters.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d329a9a4-bffc-4b44-a18d-0957319db79f
📒 Files selected for processing (5)
.github/actions/pull-request/action.yml.github/workflows/ci.ymlpo/POTFILES.inpo/gen-potfiles.pypo/meson.build
💤 Files with no reviewable changes (1)
- .github/actions/pull-request/action.yml
📜 Review details
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-03-08T15:48:59.252Z
Learnt from: amezin
Repo: ddterm/gnome-shell-extension-ddterm PR: 1801
File: .github/workflows/ci.yml:132-137
Timestamp: 2026-03-08T15:48:59.252Z
Learning: In CI workflows (e.g., .github/workflows/*.yml) avoid enforcing meson subprojects download in lint-like jobs if the typical developer workflow includes running meson setup, which downloads subprojects. Treat missing subproject downloads as a concern only for jobs that do not run meson setup (e.g., lint). If a workflow runs meson setup, do not flag lint entrypoints for missing subproject downloads.
Applied to files:
.github/workflows/ci.yml
📚 Learning: 2026-05-12T20:24:18.229Z
Learnt from: amezin
Repo: ddterm/gnome-shell-extension-ddterm PR: 1908
File: .github/workflows/ci.yml:309-326
Timestamp: 2026-05-12T20:24:18.229Z
Learning: In this repo’s CI workflows, assume the `meson dist` tarball includes all git-tracked files, including `.github/actions/`. After extracting the dist tarball in a CI job (e.g., `tar xvf ... --strip-components=1`), it is valid to reference local actions directly via `uses: ./.github/actions/<action>` without performing a separate `actions/checkout` step. When reviewing, ensure the workflow extracts the dist tarball before any `uses: ./.github/actions/...` and that the dist packaging indeed includes `.github/actions/`; if the dist output would omit it, require adding a checkout step or otherwise ensuring those action files are present.
Applied to files:
.github/workflows/ci.yml
🔇 Additional comments (4)
po/gen-potfiles.py (1)
61-61: LGTM!po/POTFILES.in (1)
3-3: LGTM!po/meson.build (1)
5-11: LGTM!Also applies to: 25-25
.github/workflows/ci.yml (1)
411-414: LGTM!
Comment on lines
+423
to
+430
| - name: Diff translations | ||
| run: >- | ||
| git diff | ||
| --color | ||
| '--ignore-matching-lines=^"POT-Creation-Date: ' | ||
| '--ignore-matching-lines=^"Report-Msgid-Bugs-To: ' | ||
| 'po/*.po' | ||
| 'po/*.pot' |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Do not keep Weblate-owned POT files in this CI contract.
The pathspec still includes po/*.pot, so this job continues to treat generated POT output as CI-owned synchronization data, contrary to the PR objective. Scope this check to po/*.po and remove the POT update/check from this job.
Proposed pathspec change
'po/*.po'
- 'po/*.pot'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Diff translations | |
| run: >- | |
| git diff | |
| --color | |
| '--ignore-matching-lines=^"POT-Creation-Date: ' | |
| '--ignore-matching-lines=^"Report-Msgid-Bugs-To: ' | |
| 'po/*.po' | |
| 'po/*.pot' | |
| - name: Diff translations | |
| run: >- | |
| git diff | |
| --color | |
| '--ignore-matching-lines=^"POT-Creation-Date: ' | |
| '--ignore-matching-lines=^"Report-Msgid-Bugs-To: ' | |
| 'po/*.po' |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yml around lines 423 - 430, Update the “Diff
translations” workflow step to remove the po/*.pot pathspec, leaving the git
diff check scoped only to po/*.po. Preserve the existing ignored translation
metadata lines and all other CI behavior.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make this translation check fail on differences.
Unlike the POTFILES check, this git diff omits --exit-code, so .po/.pot changes are printed but the step still succeeds. Add --exit-code.
Proposed fix
git diff
+ --exit-code
--color📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - name: Diff translations | |
| run: >- | |
| git diff | |
| --color | |
| '--ignore-matching-lines=^"POT-Creation-Date: ' | |
| '--ignore-matching-lines=^"Report-Msgid-Bugs-To: ' | |
| 'po/*.po' | |
| 'po/*.pot' | |
| - name: Diff translations | |
| run: >- | |
| git diff | |
| --exit-code | |
| --color | |
| '--ignore-matching-lines=^"POT-Creation-Date: ' | |
| '--ignore-matching-lines=^"Report-Msgid-Bugs-To: ' | |
| 'po/*.po' | |
| 'po/*.pot' |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ci.yml around lines 423 - 430, Update the “Diff
translations” workflow step to pass --exit-code to git diff, ensuring
differences in po/*.po or po/*.pot cause the CI step to fail while preserving
the existing ignored-line filters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.