Feat/auth switch by milo39 · Pull Request #507 · deNBI/simpleVMWebGateway

milo39 · 2025-11-05T12:29:04Z

implemented way to switch the authorization layer of the NGINX snippet by adding a new parameter only_allow_owner and a new function that reloads the research environment when wanting to change authorization.

…search environments

dweinholz · 2025-11-05T12:35:12Z

FastapiOpenRestyConfigurator/app/main/config.py

    FORC_VERSION: str = '0.2'
-    DEBUG: bool = False
-    LOG_LEVEL: str = "INFO"
+    DEBUG: bool = True #temporary !!!!!!!!!


Set it back to False for the PR

dweinholz · 2025-11-05T12:35:16Z

FastapiOpenRestyConfigurator/app/main/config.py

-    DEBUG: bool = False
-    LOG_LEVEL: str = "INFO"
+    DEBUG: bool = True #temporary !!!!!!!!!
+    LOG_LEVEL: str = "DEBUG" #temporary !!!!!!!!!


Set it back to INFO for the PR

dweinholz · 2025-11-05T12:42:38Z

FastapiOpenRestyConfigurator/app/main/model/serializers.py

        description="Inject the full url (with protocol) for the real location of the backend service in the template.",
        example="http://192.168.0.1:8787/"
    )
+    only_allow_owner: bool = Field(


That is not true -- with this setting the owner can access the backend but also additional users (where the owner have added them --> id in the /users/.. folder)

So maybe we should rename this

dweinholz · 2025-11-05T12:45:31Z

examples/templates/rstudio%v02.conf

      proxy_pass {{ location_url }};
      proxy_redirect {{ location_url }} $scheme://$http_host/{{ key_url }}/;
-      proxy_http_version 1.1;
+      proxy_http_version 1.1; @ reviewer: we have the same here. is this necessary?


Where do we have the same?

FastapiOpenRestyConfigurator/app/main/views/backend.py

dweinholz · 2025-11-05T12:50:16Z

FastapiOpenRestyConfigurator/app/main/views/backend.py

+    summary="Set owner authorization to true/false for an existing backend."
+)
+async def backend_update_auth(backend_id: int, enable_auth: bool, api_key: APIKey = Depends(get_api_key)):
+    backend_id = int(secure_filename(str(backend_id)))


Why secure_filename ?

The backend_int should just be a number (so you just could check if it is an int)

Ok this is also used in the other part of the code -- but i dont know why

dweinholz · 2025-11-05T12:53:09Z

FastapiOpenRestyConfigurator/app/main/views/backend.py



+@router.post(
+    "/backends/{backend_id}/auth/{enable_auth}",


The {enable_auth} param should be moved to the payload rather than being part of the URL (as this is not restful).

FastapiOpenRestyConfigurator/app/main/service/backend.py

dweinholz · 2025-11-05T13:10:15Z

FastapiOpenRestyConfigurator/app/main/views/backend.py

+    logger.info(f"Updating backend authorization for backend id: ${backend_id}")
+    ok = await backend_service.update_backend_authorization(backend_id, enable_auth)
+    if not ok:
+        raise HTTPException(status_code=404, detail="Backend not found or update failed.")


should differ in response:

404 -- if Backend with id not found
500 -- if something went wrong in the auth enable method itself (with the info what failed)

dweinholz · 2025-11-05T13:11:23Z

FastapiOpenRestyConfigurator/app/main/service/backend.py

    suffix_number = await generate_suffix_number(payload.user_key_url)

    payload.id = str(await random_with_n_digits(10))
+    if 'id' in kwargs: # override id and suffix if provided


Why this is needed?

…_authorization

…or different edge cases

dweinholz

Please address all comments. Feel free to comment yourself if you think the requested change is unnecessary.

dweinholz · 2025-11-06T07:26:03Z

FastapiOpenRestyConfigurator/app/main/service/backend.py

    return valid_backends


+async def get_backends_by_id(backend_id: int) -> BackendOut:


small typo should be -> get_backend_by_id

dweinholz · 2025-11-06T07:34:36Z

FastapiOpenRestyConfigurator/app/main/views/backend.py

+    try:
+        await backend_service.update_backend_authorization(backend_id, enable_auth)
+    except NotFound:
+        raise HTTPException(status_code=404, detail="Backend not found.")


->

f"Backend with id {id} not found" (makes it easier to debug later via logs etc)

dweinholz · 2025-11-06T07:36:17Z

FastapiOpenRestyConfigurator/app/main/views/backend.py

+    except NotFound:
+        raise HTTPException(status_code=404, detail="Backend not found.")
+    except InternalServerError:
+        raise HTTPException(status_code=500, detail="Internal server error.")


Add the error msg to the detail:

("Could not extract proxy_pass from {backend.file_path}" (also add the backend id) etc..

dweinholz

Please also update the BackendOut so that the auth info is also present there

dweinholz · 2025-11-06T07:43:17Z

FastapiOpenRestyConfigurator/app/main/views/backend.py

+        raise HTTPException(status_code=404, detail="Backend not found.")
+    except InternalServerError:
+        raise HTTPException(status_code=500, detail="Internal server error.")
+    return {"auth": f"{str(enable_auth).lower()}"}


Should also return BackendOut

Please also update the BackendOut so that the auth info is also present there

…refactors for readability, changes to upstream_url_regex

…mproved logging

…s/backend.py

…gic, also organized the functions

…helper functions

…ts to service/backend.py WIP

…d.py

…tests for duplicate backend deletion

…_check_backend_path_file

…function

…unctions

…lenames, minor changes in service/backend.py

Ubuntu added 2 commits October 31, 2025 13:42

initial commit, added API call and dynamically generated .conf for re…

6e9d272

…search environments

fixed issue with theiaide and rstudio, should be working now

bad4cb7

milo39 requested review from dweinholz and qqmok November 5, 2025 12:29

milo39 changed the base branch from master to dev November 5, 2025 12:32

dweinholz requested changes Nov 5, 2025

View reviewed changes

milo39 added 2 commits November 5, 2025 18:19

added get_backends_by_id(int id) and implemented it in update_backend…

1d604ff

…_authorization

backend_update_auth now has different exception responses (404/500) f…

ee09ea5

…or different edge cases

milo39 requested a review from dweinholz November 5, 2025 18:54

dweinholz requested changes Nov 6, 2025

View reviewed changes

minor corrections

b434472

dweinholz requested a review from vktrrdk November 21, 2025 09:35

dweinholz assigned vktrrdk and milo39 Nov 21, 2025

milo39 and others added 15 commits November 27, 2025 00:15

implemented and fixed switch function with auth status output. minor …

1601e3b

…refactors for readability, changes to upstream_url_regex

refactored update backend authorization flow, changed return types, i…

60251d8

…mproved logging

started adding unit tests for views/backend.py and service/backend.py

99f93fa

unfinished, wrote unit tests for parts of service/backend.py and view…

eee4076

…s/backend.py

test

e2d0972

Added helper functions and refactored backend authorization update lo…

9e8c631

…gic, also organized the functions

backend service: refactored and debloated create_backend() by adding …

e92f18f

…helper functions

refactored delete_backend() by splitting into sub functions

0ad366a

removed unneccessary async calls and commented out existing functions

bc80914

testing environment, added some test functions

81ef9b5

feat(Tests):updated tests (#535) and also some changes in templating

d7ff550

finished test_views_backend, started test_service_backend, improvemen…

9c6a722

…ts to service/backend.py WIP

added tests to test_service_backend.py, corrections to service/backen…

0cca71c

…d.py

refactored some backend functions for clarity and consistency; added …

cd9f4eb

…tests for duplicate backend deletion

added tests to service/backend.py

55ce4da

milo39 added 8 commits January 21, 2026 19:34

added further tests

e06af18

finished test_convert_backend_temp_to_out, added conftest.py and test…

8708a23

…_check_backend_path_file

finished test_check_backend_path_file()

0bbf613

finished test_check_backend_path_file_naming and changed to original …

9d0c857

…function

added helper_create_backend_file, might need to refactor to mock os f…

a91b76b

…unctions

refactored tests to mock os functions, added test_get_backend_path_fi…

bac4dc1

…lenames, minor changes in service/backend.py

fixed issue with create_instance

f274bc9

cleaned up some log calls

8d79b6b

		return valid_backends


		async def get_backends_by_id(backend_id: int) -> BackendOut:



		@router.post(
		"/backends/{backend_id}/auth/{enable_auth}",

Conversation

milo39 commented Nov 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dweinholz Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

The backend_int should just be a number (so you just could check if it is an int)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dweinholz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dweinholz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dweinholz Nov 5, 2025 •

edited

Loading

dweinholz left a comment •

edited

Loading