feat: clear decentraland-connect storage on wallet disconnect#45
Merged
LautaroPetaccio merged 1 commit intomasterfrom Apr 2, 2026
Merged
Conversation
Sites using decentraland-connect clear the `decentraland-connect-storage-key` localStorage entry when disconnecting. Without this, users who disconnect through core-web3 leave stale connection metadata behind, which can cause those sites to mistakenly believe a wallet is still connected.
braianj
approved these changes
Apr 2, 2026
Pull Request Test Coverage Report for Build 23925396945Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decentraland-connectclear thedecentraland-connect-storage-keylocalStorage entry when a user disconnects their wallet. Without matching this behavior incore-web3, a disconnect here leaves stale connection metadata (provider type and chain ID) behind, which can cause those sites to still see the user as connected.clearConnectionStoragefunction (mirroringdecentraland-connect'sConnectionManager.clearConnectionData) and calls it from theuseWalletdisconnect callback so both libraries stay in sync.useWallet.How it works
clearConnectionStorage()insrc/config/wagmi.tsremoves thedecentraland-connect-storage-keyfrom localStorage, with SSR safety guards.disconnectcallback inuseWalletnow callsclearConnectionStorage()right afterwagmiDisconnect().Test plan
clearConnectionStorageunit tests: removes the expected key, no-ops whenwindowis undefineduseWalletdisconnect test: verifiesclearConnectionStorageis called on disconnect