fix: ab registry manifest fallback case sensitivity + lsd manifest fallback#7956
fix: ab registry manifest fallback case sensitivity + lsd manifest fallback#7956lorenzo-ranciaffi wants to merge 12 commits intodevfrom
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
|
Claude finished @lorenzo-ranciaffi's task in 2m 59s —— View job PR Review
The fixes are correct and well-targeted. The case-insensitive dictionary ( Two inline comments posted. One additional finding that couldn't be placed inline:
REVIEW_RESULT: PASS ✅ |
Explorer/Assets/DCL/AvatarRendering/Loading/Systems/LoadElementsByPointersSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Emotes/Systems/Load/LoadEmotesByPointersSystem.cs
Outdated
Show resolved
Hide resolved
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
|
Claude finished @lorenzo-ranciaffi's task in 3m 13s —— View job PR Review
The core fixes are solid: case-insensitive dictionary for AB registry matching, AB registry integration in One finding: Constructor visibility — Both REVIEW_RESULT: PASS ✅ |
Explorer/Assets/DCL/AvatarRendering/Wearables/Systems/Load/LoadWearablesDTOByPointersSystem.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/AvatarRendering/Emotes/Systems/Load/LoadEmotesByPointersSystem.cs
Outdated
Show resolved
Hide resolved
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
|
Claude finished @lorenzo-ranciaffi's task in 1m 52s —— View job Claude finished @lorenzo-ranciaffi's task —— View job PR Review
All previous review findings have been addressed:
No new issues found. The REVIEW_RESULT: PASS ✅ |
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
|
Claude finished @lorenzo-ranciaffi's task in 2m 13s —— View job PR Review
All previous review findings have been addressed. One minor issue found in this sync:
Everything else is correct:
REVIEW_RESULT: PASS ✅ |
Explorer/Assets/DCL/AvatarRendering/Loading/Systems/LoadElementsByPointersSystem.cs
Outdated
Show resolved
Hide resolved
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
|
Claude finished @lorenzo-ranciaffi's task in 2m 47s —— View job PR Review
All previous review findings have been addressed and no new issues found in this sync:
REVIEW_RESULT: PASS ✅ |
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
Explorer/Assets/DCL/Infrastructure/ECS/StreamableLoading/AssetBundlesVersions.cs
Outdated
Show resolved
Hide resolved
Explorer/Assets/DCL/NetworkDefinitions/Browser/DecentralandUrlsSource.cs
Show resolved
Hide resolved
|
Claude finished @lorenzo-ranciaffi's task in 2m 46s —— View job PR Review
All previous review findings have been addressed. No new issues found in this sync. Verified clean:
REVIEW_RESULT: PASS ✅ |
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
|
Claude finished @lorenzo-ranciaffi's task in 3m 5s —— View job Claude finished reviewing — PR Review
All previous review findings remain addressed. No new issues found in this sync. Verified clean:
REVIEW_RESULT: PASS ✅ |
|
Claude finished @lorenzo-ranciaffi's task in 1m 16s —— View job PR Review
All previous review findings have been addressed. No new issues found in this sync. Verified clean:
REVIEW_RESULT: PASS ✅ |
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
1 similar comment
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
PR 7956PR number: 7956 Intel Core i3Change samples: 2670
|
PR 7956PR number: 7956 Intel Core i3Change samples: 2672
|
PR 7956PR number: 7956 Intel Core i3Change samples: 2668
|
|
Claude finished @lorenzo-ranciaffi's task in 1m 20s —— View job PR Review
All previous review findings remain addressed. No new issues found in this sync (merge of Verified clean:
REVIEW_RESULT: PASS ✅ |
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
|
PR #7956, run #23907720450 Builds: Windows change, Windows baseline, macOS change, macOS baseline Intel Core i3
|
|
Claude finished @lorenzo-ranciaffi's task in 1m 51s —— View job PR Review
All previous review findings remain addressed. No new issues found in this sync. Verified clean:
REVIEW_RESULT: PASS ✅ |
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
|
Claude finished @lorenzo-ranciaffi's task in 2m 41s —— View job PR Review
All previous review findings remain addressed. No new issues found in this sync. Verified clean:
REVIEW_RESULT: PASS ✅ |
|
🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging. |
Pull Request Description
Fixes #7608
What does this PR change?
This PR makes sure that AB registry version result is case insensitive: many offchain wearables have capital letters that before weren't matching. E.g.:
Where ever an Emote or Wearable is requested, the AB Registry is used (LSD included) so that the manifest is always present.
On top of that I noticed that when the inventory page had only base emotes, a request to the registry was made with an empty
pointersarray, causing a 400 log. With an early exit, this is now prevented.Test Instructions
Test Steps
AssetBundleManifestFallbackHelper: AB Manifest Fallback requestedmessage is spotted in the logQuality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.