Skip to content

fix: supress errors for headers call in open media#8099

Open
alejandro-jimenez-dcl wants to merge 2 commits intodevfrom
fix/open-media-404-error
Open

fix: supress errors for headers call in open media#8099
alejandro-jimenez-dcl wants to merge 2 commits intodevfrom
fix/open-media-404-error

Conversation

@alejandro-jimenez-dcl
Copy link
Copy Markdown
Contributor

@alejandro-jimenez-dcl alejandro-jimenez-dcl commented Apr 6, 2026

Pull Request Description

What does this PR change?

https://decentraland.sentry.io/issues/6428116480/
Suppresses error logging for HEAD reachability checks in OpenMediaPromise when validating media stream URLs

Test Instructions

  1. Enter a scene that uses video streaming.
  2. Verify the media plays correctly.
  3. Check the logs, no 404 specifically in 40,54

Given how important video streaming is, please check as many scenes and examples as possible.

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

@alejandro-jimenez-dcl alejandro-jimenez-dcl marked this pull request as ready for review April 7, 2026 07:49
@alejandro-jimenez-dcl alejandro-jimenez-dcl requested review from a team as code owners April 7, 2026 07:49
@github-actions github-actions bot requested a review from anicalbano April 7, 2026 07:49
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 7, 2026

Claude finished @alejandro-jimenez-dcl's task in 35s —— View job


PR Review

  • Read changed files
  • Analyze code quality and correctness
  • Post review findings

No issues found. The implementation is correct:

  • suppressErrors = true is threaded cleanly through IsHeadReachableAsyncHeadAsyncSendAsync, suppressing ReportHub.LogError in WebRequestController.cs:97 for expected 404s during HEAD reachability checks.
  • The existing fallback to IsGetReachableAsync on failure is preserved.
  • GenericDownloadHandlerUtils.cs correctly passes suppressErrors to the constructor instead of hardcoding false.

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
QA_REQUIRED: YES

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by Claude — simple fix/chore with no blocking issues. QA approval is still required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants