fix(codebuddy-cn): strip empty tool_calls arrays to preserve reasoning#2230
Open
zmf963 wants to merge 1 commit into
Open
fix(codebuddy-cn): strip empty tool_calls arrays to preserve reasoning#2230zmf963 wants to merge 1 commit into
zmf963 wants to merge 1 commit into
Conversation
CodeBuddy CN API includes `"tool_calls": []` (empty array) in every SSE streaming delta. @ai-sdk/openai-compatible checks `delta.tool_calls != null` — an empty array passes this check ([] != null is true in JS), triggering premature `reasoning-end` on every chunk that contains reasoning_content. This causes tools like OpenCode to show zero or 1ms reasoning durations instead of the actual thinking time. Fix: in passthrough mode, delete empty tool_calls arrays from delta before hasValuableContent filtering. This is a zero-side-effect change — real tool_calls always have at least one element. Closes decolua#2176
zmf963
force-pushed
the
fix/codebuddy-cn-empty-tool-calls
branch
from
d56f953 to
406d590
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeBuddy CN API includes
"tool_calls": [](empty array) in every SSE streaming delta. @ai-sdk/openai-compatible checksdelta.tool_calls != null— an empty array passes this check ([] != null is true in JS), triggering prematurereasoning-endon every chunk that contains reasoning_content.This causes tools like OpenCode to show zero or 1ms reasoning durations instead of the actual thinking time.
Fix: in passthrough mode, delete empty tool_calls arrays from delta before hasValuableContent filtering. This is a zero-side-effect change — real tool_calls always have at least one element.