-
Couldn't load subscription status.
- Fork 137
Refactor scratch language and let the user specify m2c flags #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| asm.data, | ||
| context, | ||
| compiler, | ||
| compiler.language, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this problem that the scratch's language is only decided below, when it gets serialized, so for now I just passed the compiler's default language to the decompiler at scratch creation. Do you have an idea how we could determine the language beforehand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of putting together the --target flag manually, we could do the same what we do with compilers, just pass through the one defined in the preset (or scratch when the user decompiles after creation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably have default language for compilers* and then bite the bullet and dedicated field on the scratch...? if it makes the most sense. I try to avoid adding fields to Scratch, but maybe this one is actually worth it
* I know we currently have compiler.language but we seem to rarely override it from C, where it should most likely be C++ for any gc/wii compilers.
|
I'm like 80% done with the feature. Have to get it to work and then we can start testing. :) |
|
We have some things that are all queried from the backend and filtered on the frontend like |
|
Have to remove TODO comments.
|
Will solve #1418. Decided to push my work so far, so we can discuss it as I work.