fix: DH-20415: AG Grid headers should match column names#1261
Merged
mofojed merged 6 commits intodeephaven:mainfrom Nov 13, 2025
Merged
fix: DH-20415: AG Grid headers should match column names#1261mofojed merged 6 commits intodeephaven:mainfrom
mofojed merged 6 commits intodeephaven:mainfrom
Conversation
- Previously we were omitting the `headerName` property of the column definition. When omitted, AG Grid automatically reformats the header name and adds spaces if it is a PascalCase header name - Explicitly define `headerName` in the ColumnDefinition to match the actual name of the column
mofojed
force-pushed
the
DH-20415-ag-grid-header-name
branch
from
6b0a0e1 to
b34830a
Compare
mattrunyon
reviewed
Nov 11, 2025
mattrunyon
previously approved these changes
Nov 13, 2025
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Looks like there's an e2e snapshot merge conflict
mattrunyon
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
headerNameproperty of the column definition. When omitted, AG Grid automatically reformats the header name and adds spaces if it is a PascalCase header nameheaderNamein the ColumnDefinition to match the actual name of the column