Skip to content

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Jan 2, 2026

Cherry-pick #2597

Update GridUtils.getColumnSeparatorIndex to take column group depth into account.

BREAKING CHANGE: getColumnSeparatorIndex now requires a model argument.

@vbabich vbabich self-assigned this Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.44%. Comparing base (bb592e9) to head (fbf1ac7).
⚠️ Report is 1 commits behind head on release/v0.85.

Files with missing lines Patch % Lines
packages/grid/src/GridUtils.ts 60.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release/v0.85    #2599   +/-   ##
==============================================
  Coverage          48.44%   48.44%           
==============================================
  Files                712      712           
  Lines              39747    39760   +13     
  Branches            9921     9929    +8     
==============================================
+ Hits               19255    19263    +8     
- Misses             20479    20484    +5     
  Partials              13       13           
Flag Coverage Δ
unit 48.44% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich marked this pull request as ready for review January 2, 2026 19:54
@vbabich vbabich requested a review from bmingles January 2, 2026 19:54
@vbabich vbabich changed the title fix: DH-21258: Fix column group separators fix: Cherry-pick DH-21258: Fix column group separators Jan 2, 2026
@vbabich vbabich enabled auto-merge (squash) January 2, 2026 19:55
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbabich vbabich merged commit 44edc02 into deephaven:release/v0.85 Jan 2, 2026
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants