[GPU] Fix/Improve force calculation on DCU platform#6823
Merged
Conversation
kunkunblueberry
force-pushed
the
fix_force
branch
3 times, most recently
from
January 4, 2026 10:15
8014b50 to
0374b31
Compare
kunkunblueberry
marked this pull request as ready for review
January 4, 2026 10:18
kunkunblueberry
marked this pull request as draft
January 4, 2026 10:21
kunkunblueberry
marked this pull request as ready for review
January 4, 2026 10:26
kunkunblueberry
marked this pull request as draft
January 7, 2026 06:20
kunkunblueberry
force-pushed
the
fix_force
branch
from
January 7, 2026 06:44
0374b31 to
27cbfbf
Compare
kunkunblueberry
marked this pull request as ready for review
January 7, 2026 06:47
Collaborator
|
Please modify the title of PR and link the realted issue. |
dyzheng
approved these changes
Jan 7, 2026
dyzheng
left a comment
Collaborator
There was a problem hiding this comment.
LTGM for this PR. 204_NO_KP_NC should be updated in LTS branch, I will check it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
Related to #6815
Unit Tests and/or Case Tests for my changes
pre-commit-ci/lite-actionstep, specifically throwingurllib.error.HTTPError: HTTP Error 400: Bad Request._save_artifactexecution and is not a flaw in the code logic. It is likely triggered by extensive auto-formatting of files such ashelper_cuda.h, resulting in a Diff Patch that exceeds GitHub API upload limits. The stability of the specific Action version (v1.0.3) may also be a contributing factor.What's changed?
force.cpp, where interfaces for different GPU platforms have been adapted and adjusted.cal_force_loc_sincos_ophave been implemented within themodule_hsolverCUDA kernels to optimize the operator logic for force calculations.Any changes of core modules?