fix: skip invalid docling serve sources#3150
Draft
turkeshp wants to merge 5 commits into
Draft
Conversation
Add a new DoclingServeConverter component that converts documents via a running docling-serve REST API instance, avoiding docling's heavy local dependencies (PyTorch, etc.). Relates to deepset-ai#2960 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The API reference build expects docling_serve.md (matching the integration folder name), not docling-serve.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pytest exits with code 5 when no tests are collected. The integration test step selects only @pytest.mark.integration tests, which were missing. Add a skipped integration test that runs when DOCLING_SERVE_URL is set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
topic:CI
type:documentation
|
|
turkeshp
changed the title
Contributor
|
Hey @turkeshp could you recheck if your changes are needed? We recently updated the docling serve integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
DoclingServeConverter.run()run_async()How did test it?
python -m py_compile src\haystack_integrations\components\converters\docling_serve\converter.py tests\test_converter.pypython -m pytest tests\test_converter.py -q -k missing_file_logged_and_skippedNotes for the reviewer
This PR is intentionally small and builds on top of
#3139.It does not change the integration design; it only makes invalid local file inputs non-fatal in sync and async conversion.
Checklist
I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title
This is a follow-up on top of #3139, not a competing implementation.
The only intended change here is making invalid local sources non-fatal in
run()andrun_async(), with focused test coverage for that behavior.Happy to work this PR and have the fix cherry-picked into #3139 if that is the preferred workflow.