feat(supabase): add SupabaseGroongaDocumentStore and SupabaseGroongaRetriever#3266
feat(supabase): add SupabaseGroongaDocumentStore and SupabaseGroongaRetriever#3266ShubhamGond105 wants to merge 31 commits into
Conversation
…m write behaviour
|
Hi @davidsbatista, count argument type error — need to use CountMethod.exact instead of "exact" string |
|
Can you confirm that the client doesn't support async operations? You did not add any do the |
| ) | ||
|
|
||
| @component.output_types(documents=list[Document]) | ||
| def run( |
There was a problem hiding this comment.
Can you also define an async def run_async(...) ? Does the client supports it?
|
Hi @ShubhamGond105, thanks for your contribution. I left some comments that need to be addressed; also, the type-checking issues need to be fixed. In the future, please make sure the CI is green before asking for a review, unless the reason why is not green is out of your control and needs our action. Thanks once again! |
Coverage report (supabase)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
|
"Hi @davidsbatista, I've addressed all the feedback points: Moved client initialization to warm_up() All tests passing locally. Please take a look when you get a chance!" |
|
Tests are failing on the CI; we need to have them fixed |
|
There are no integration tests:
Please make sure you go through this, we need to have integration tests. |
| self, | ||
| *, | ||
| supabase_url: str, | ||
| supabase_key: Secret = Secret.from_env_var("SUPABASE_SERVICE_KEY"), |
There was a problem hiding this comment.
| supabase_key: Secret = Secret.from_env_var("SUPABASE_SERVICE_KEY"), | |
| supabase_key: Secret = Secret.from_env_var("SUPABASE_SERVICE_KEY", strict=False) |
|
There are still a few unresolved issues, and no integration tests - please go through them and let me know if you need any help. When in doubt, look at how other DocumentStores work (e.g., retrievers logic, filters, etc.) and replicate it - ElasticSearch and OpenSearch document stores have good patterns to follow |
|
Hi @ShubhamGond105 - do you still have time to work on this? |
|
Yes but I need more time to fix it. |
…d105/haystack-core-integrations into feat/supabase-groonga
Related Issues
SupabaseGroongaDocumentStoreandSupabaseGroongaRetriever#3083Proposed Changes:
Adds
SupabaseGroongaDocumentStoreandSupabaseGroongaRetrieverfor full-text search powered by PGroonga, a PostgreSQL extension for fast multilingual full-text search exposed by Supabase.SupabaseGroongaDocumentStore: stores and searches documents using PGroonga full-text search — no embeddings neededSupabaseGroongaRetriever: retrieves documents using plain text queriesSupabasePgvectorEmbeddingRetrieverin hybrid search pipelinesHow test
19 unit tests covering:
Notes for the reviewer
Checklist
feat: