feat: add CLIENT SETNAME for connection identification#3365
Open
atao2004 wants to merge 1 commit into
Open
Conversation
Adds client_name="haystack_vector_store_client" to all 4 Glide client configurations (sync/async, standalone/cluster) so connections are identifiable via CLIENT LIST on the server. Fixes deepset-ai#3356 Signed-off-by: Anna Tao <annatao2004@gmail.com>
|
|
Contributor
Coverage report (valkey)
This PR does not seem to contain any modification to coverable code. |
Member
|
Thank you for raising the issue and opening this pull request @atao2004 ! We need you to agree to the CLA please before we can merge this pull request. #3365 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Adds
client_name="haystack_vector_store_client"to all 4 Glide client configurations (sync/async, standalone/cluster) indocument_store.py. This sends aCLIENT SETNAMEcommand on connection, making Haystack connections identifiable inCLIENT LIST, monitoring dashboards, and CloudWatch metrics.How did you test it?
Manual verification —
client_nameis a metadata-only parameter passed to the Glide client configuration. It does not alter any behavior, only sets the connection name visible inCLIENT LIST.Notes for the reviewer
Zero-risk change —
client_nameis a standard parameter onGlideClientConfiguration(and all variants). It sendsCLIENT SETNAMEafter connecting. No behavioral changes.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.