Skip to content

cleanup outdated dirs #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2016
Merged

cleanup outdated dirs #266

merged 1 commit into from
Sep 11, 2016

Conversation

glensc
Copy link
Contributor

@glensc glensc commented May 17, 2016 •
edited
Loading

  • random_compat is no longer in sourcetree
  • the "other" dir was obliterated
  • skip composer "vendor" instead

ps: "dist" dir does not to be excluded, as it does not contain *.php files

ps2: two files need php-cs fix:

   1) KeyProtectedByPassword.php (single_quote)
   2) unit/EncodingTest.php (ordered_use)

@paragonie-scott paragonie-scott mentioned this pull request Jul 13, 2016
Closed
sstok
sstok reviewed Jul 23, 2016
View reviewed changes
.php_cs
)
->in('src')
->in('test')
->exclude('vendor')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendor is already excluded by default 👍
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/1.11/Symfony/CS/Finder/DefaultFinder.php#L36

@defuse defuse merged commit 174673e into defuse:master Sep 11, 2016
@glensc glensc deleted the random_compat-clean branch September 11, 2016 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glensc @sstok @defuse