CIDR network string - #1032
Merged
Merged
Conversation
nitesh3108
requested review from
HarishH-DELL,
JacobGros,
alexemc,
alikdell,
atye,
chaganti-rajitha,
chimanjain,
meggm,
niranjan-n1,
panigs7,
rajendraindukuri,
shanmydell,
sharmilarama,
shaynafinocchiaro,
shefali-malhotra,
tdawe and
tssushma
as code owners
June 29, 2026 13:13
alikdell
approved these changes
Jun 29, 2026
meggm
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
No
What this PR does / why we need it:
Updates the allowedNetworks parameter in charts/csi-isilon/values.yaml from a YAML list ([]) to a quoted string (""). This aligns the Helm chart value format with how the CSI PowerScale driver actually parses the allowed networks configuration — as a single comma-separated string rather than a native YAML list. The comment and example are updated to reflect the expected format: a quoted, bracketed, comma-separated string of CIDR ranges (e.g., "[192.168.1.0/24, 192.168.100.0/22]"). Also clarifies that the driver selects the first node IP falling within any of the specified CIDR ranges.
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable