Conversation
ghost
assigned
|
Cool work! How fast is it? |
Codecov Report
@@ Coverage Diff @@
## develop #32 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 9 10 +1
Lines 200 199 -1
Branches 8 10 +2
=====================================
+ Misses 200 199 -1
Continue to review full report at Codecov.
|
| scalaVersion := "2.12.4" | ||
|
|
||
| name := "delphi" | ||
| name := "delphi-cli" |
There was a problem hiding this comment.
The executable generated will take this name. So I have renamed it. I can revert if it is a issue.
There was a problem hiding this comment.
Yes, that's why i actually renamed it. :)
This way the users can enter delphi and not delphi-cli.
I think this ways its a bit stronger. What do you think?
There was a problem hiding this comment.
Ok then revert it to delphi. In documentation delphi-cli is used I renamed because of that https://github.com/delphi-hub/delphi-cli.
bhermann
left a comment
bhermann
left a comment
There was a problem hiding this comment.
Please check for code style issues and the question mentioned above. Thanks. 😄
|
@hariharansrc could you take care of this? |
|
@bhermann Sorry I didn't not get any notification.I will do it now. |
|
No worries... Thank you! :-) |
1 similar comment
|
No worries... Thank you! :-) |
3 participants
Move away from akka http #27