DLPX-93763 GCP cloud-init may allow privileged user creation#108
Closed
david-mendez1 wants to merge 2 commits intodevelopfrom
Closed
DLPX-93763 GCP cloud-init may allow privileged user creation#108david-mendez1 wants to merge 2 commits intodevelopfrom
david-mendez1 wants to merge 2 commits intodevelopfrom
Conversation
david-mendez1
force-pushed
the
dlpx/pr/david-mendez1/724e0754-e0bb-493d-8912-971a42d9d13a
branch
from
29132aa to
8866b7c
Compare
jwk404
approved these changes
Mar 27, 2025
Contributor
jwk404
left a comment
jwk404
left a comment
There was a problem hiding this comment.
LGTM, pending a good test run.
* Add .whitesource configuration file * DLPX-93075 Configure Mend for cloud-init --------- Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: Shibasish Nandi <119420781+ShibasishDelphix@users.noreply.github.com>
david-mendez1
force-pushed
the
dlpx/pr/david-mendez1/724e0754-e0bb-493d-8912-971a42d9d13a
branch
from
8866b7c to
9dd1b8f
Compare
Author
|
Fix not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Recently, a customer provided examples of privileged shell access with a custom user created on a GCP deployment. This seemed to indicate that an arbitrary user was created, possibly during VM creation.
In further review and discussion with others in #dlpx-gcp Slack room, it appears that user-metadata can be leveraged to ‘insert’ operations via cloud-init and thereby create additional users on the Delphix VM.
Originally Delphix removed the module `users-groups` from cloud.cfg.tmpl to avoid this issue of being able to create a user. 2 yrs ago, upstream changed the format of the cloud init modules to use underscores rather than hyphens. During a merge conflict, we inadvertently merged the unwanted `users_groups` back into cloud.init.Problem
canonical/cloud-init#4272
Solution
Remove
users_groupsfrom cloud.cfg.tmplTesting Done
https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/10685/
Note: upgrade failed due to know bug https://perforce.atlassian.net/browse/DLPX-93809