fix: nested tag deletion - #54
Open
nekomaido wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix nested tag deletion leaving orphaned tags hidden from the sidebar.
Deleting a parent tag now deletes all of its descendants. Existing tags whose
parent was deleted are restored to the root during migration, so they become
visible in the sidebar again.
Also prevents moving a tag under one of its own descendants, which would create
a circular hierarchy.
How to reproduce on the old version
Favedtag.Old behavior
Favedand its direct childDocsare deleted.Getting startedandGuidesremain, but their parent (Docs) no longerexists.
deleted there.
New behavior
Favedalso deletes all of its descendant tags.