Skip to content

move to jsr for dependencies and modernize some things #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 21, 2025

Conversation

williamhorning
Copy link
Contributor

@williamhorning williamhorning commented Aug 23, 2024

This pr renames the jsr package so that it uses the @db scope (used by the mongo and sqlite drivers), moves the dependency on the standard library over to the jsr ones, updates those dependencies, and replaces code that relies on deprecated functions.

fixes: #482
fixes: #481
fixes: #480

@bombillazo
Copy link
Collaborator

merge main to your branch again

@williamhorning
Copy link
Contributor Author

williamhorning commented Dec 21, 2024

@bombillazo can you take a look at this again? I merged the branches again and added a few changes to deal with Deno 2 as well. Additionally, the tests which failed here passed locally, so it seems as though something is off with Github Actions

Copy link
Collaborator

@bombillazo bombillazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I have some minor questions.

@williamhorning
Copy link
Contributor Author

@bombillazo is there any chance you can run the workflows for the latest commit here?

@bombillazo
Copy link
Collaborator

Hey, its still failing some minor checks

@williamhorning
Copy link
Contributor Author

the majority of checks should work now, though i'm not sure why this last one isn't working. i'll keep taking a look though

@williamhorning
Copy link
Contributor Author

hey! all the tests should pass now, if you can run them again

@bombillazo
Copy link
Collaborator

Still some errors :/ @williamhorning see if adding --allow-env to the test docs command helps

@williamhorning
Copy link
Contributor Author

hi @bombillazo! after running those tests locally with that flag, a lot of the tests fail due to being really simplified and/or incomplete code samples, such as the following:

import { Client } from "https://deno.land/x/postgres/mod.ts";
const client = new Client({ user: "user", database: "test" });
const id = 12;
// Array<[number, string]>
const { rows } = await transaction.queryArray<[number, string]>`SELECT ID, NAME FROM CLIENTS WHERE ID = ${id}`;

to fix all of these short snippets and the ci would require some effort, which would be worth it, but i feel as though that (along with possibly redoing the docs site) would be better fit for another pr. either way, i'd be happy to work on doing that if that's desired

@williamhorning
Copy link
Contributor Author

hey @bombillazo, i took another look at this and i think i've solved all of the problems with the docs test, could you approve the workflow run please?

@williamhorning
Copy link
Contributor Author

looks like the tests were doing something weird locally, but that should be fixed now. also, would you like me to update the info and links in the README and docs to point to JSR, or would you rather that be done in a separate PR?

@bombillazo
Copy link
Collaborator

I could be done in this same PR

@bombillazo
Copy link
Collaborator

@williamhorning Thank you for your dedication and contribution.

@bombillazo bombillazo merged commit b22f743 into denodrivers:main Apr 21, 2025
3 checks passed
@bombillazo
Copy link
Collaborator

@williamhorning
Copy link
Contributor Author

see #499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename JSR package? Convert source to JSR dependencies JSR Outdated
2 participants