-
Notifications
You must be signed in to change notification settings - Fork 332
Update Lume #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Lume #2501
Conversation
Setting // deno.json
{
"compilerOptions": {
"types": [
"lume/types.ts"
],
- "jsx": "react-jsx",
+ "jsx": "precompile",
"jsxImportSource": "npm:preact"
},
} |
@marvinhagemeister Good point! I just changed it and the rendering time for layouts is now |
…d#1481) Co-authored-by: Jo Franchetti <[email protected]>
I have updated this PR with the latest changes and all conflicts are resolved.
One of the changes of Lume 3 is the use of deno/loader for esbuild instead of relying on esm.sh. Do you know if there's a way to use a polyfill for |
It's probably better to use the npm package rather than the jsr one. The npm package ships with various entry points for browsers, deno and other runtimes. Such a feature doesn't exist on JSR. |
NPM has the same error. |
This PR upgrades the codebase to Lume 3 and introduces some improvements:
*.client.js
files have been moved to a subdirectory and the.client
sub-extension has removed since is not needed in Lume 3This PR is in draft because while I was working on this, I discover a couple of bugs in Lume (that's why I'm using a dev version). I'll ship these changes soon and will update this PR with a stable version.Edit: Lume 3.0.8 is already published