Skip to content

Conversation

thisisjofrank
Copy link
Collaborator

Move KV docs out of /classic/
Move cron and queues docs into /classic/
Update KV docs wording
Fix broken images
Update sidebars to match new placement of docs

@thisisjofrank thisisjofrank marked this pull request as ready for review October 2, 2025 13:47
@philhawksworth
Copy link
Member

In Classic, clicking the Deno KV sidebar link take you to https://deno-docs--kv-updates.deno.dev/deploy/kv/on_deploy/ which appears to be a legacy KV page and perhaps now is superceded by https://deno-docs--kv-updates.deno.dev/deploy/kv/

Screenshot 2025-10-07 at 10 07 09

Should this actually link to https://deno-docs--kv-updates.deno.dev/deploy/kv/ rather than the older classic KV summary page?

The disbar suggests we have navigated into Deploy, but the content page for "KV on Deno Deploy" includes the info box disclaimer for the Classic docs

Copy link
Member

@philhawksworth philhawksworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the one issue I have noted in a comment

@thisisjofrank
Copy link
Collaborator Author

@philhawksworth good spot, I've moved that old 'on deploy' page to /classic/kv_on_deploy and made any links that would have pointed to it point to /deploy/reference/deno-kv/ instead

@thisisjofrank thisisjofrank merged commit 4cc9621 into main Oct 7, 2025
5 of 7 checks passed
@thisisjofrank thisisjofrank deleted the kv-updates branch October 7, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants