LEAF-4427 (Code style discussion) Use return value #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaoVA
requested review from
Pelentan,
aerinkayne,
pete-nerantzinis,
shaneodd,
jampaul3,
nk2136 and
KCN8
as code owners
jampaul3
approved these changes
Jul 23, 2024
aerinkayne
approved these changes
Jul 23, 2024
Pelentan
approved these changes
Jul 23, 2024
Pelentan
added
the
With QA
mgaoVA
removed
the
With QA
|
Changing back to draft based on new feedback |
Pelentan
added
the
With QA
shaneodd
approved these changes
Jul 26, 2024
Pelentan
removed
the
With QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion: #2469 (comment)