-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature/APPEALS-46558 - Rails 6.1 upgrade (uat) (#1678)
* Removed depreciated 5.2 default represent_boolean_as_integer * caseflow-commons update - bourbon/neat removal * Rails gem updated to 6.1.7.4 * app:update bin/rails * app:update bin/rake * app:update bin/setup * app:update bin/spring * app:update bin/yarn * app:update config.ru * app:update application.rb * app:update config/boot.rb * app:update config/environment.rb * app:update config/environments/development.rb * app:update config/enviroments/production.rb * app:update config/environments/test.rb * app:update config/initializers/backtrace_silencers.rb * app:update config/initializers/filter_parameter_logging.rb * app:update config/initializers/permissions_policy.rb * app:update config/puma.rb * app:update config/routes.rb * Updated PG gem for postgres adapter * bourbon/neat code removed * Bundler version correction * final newline error fix * Review changes * ⬆️ Update `caseflow-commons` dependency to latest ref Removes `bourbon` and `neat` dependencies. * Added accidental deletion back in * 🔥 Remove `uglifier` During assets precompile in a 'production' environment, we encountered the following error: Uglifier::Error: Unexpected token: name (compare1). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true). Per the `uglifier` README: UglifyJS only works with ES5. If you need to compress ES6, `ruby-terser` is a better option. Looking at the Caseflow git history for comparison, it looks like the `uglifier` gem was removed in favor of using Webpack to perform JS compression via the `UglifyjsWebpackPlugin`. Later, the `UglifyjsWebpackPlugin` was removed when Webpack v4 incorporated the `TerserWebpackPlugin` out-of-the-box: https://github.com/department-of-veterans-affairs/caseflow-efolder/blob/9853eaeb98692099f1e62435de9a4dc08292fa53/client/yarn.lock#L6119 It appears that there may need to be some additional configuration added to the `webpack.config.js` file in order to leverage the Terser plugin: https://v4.webpack.js.org/plugins/terser-webpack-plugin/ However, the Caseflow `webpack.config.js` does not include the Terser configuration at this time, and so, in keeping parity with Caseflow, we will omit this configuration in eFolder as well and leave it as a future exercise should it be necessary to enact JS compression. * ⏪️ Restore overrides for `config.action_dispatch.use_authenticated_cookie_encryption` and `config.action_dispatch.use_cookies_with_metadata` While testing in PreProd, we discovered that, without these cookie config overrides, re-authentication was broken -- after logging out, a user could not log back in. Since the default settings are still optional going forward, we can restore these overrides and devise a solution to migrate cookies later. For more details, see Jira story APPEALS-54897: https://jira.devops.va.gov/browse/APPEALS-54897 * PG updated to 1.5.7 * PG regressed from 1.5.7 to 1.1.4 for seperate branches --------- Co-authored-by: Alec Kagebein <[email protected]>
- Loading branch information
Showing
21 changed files
with
217 additions
and
169 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/usr/bin/env ruby | ||
| APP_PATH = File.expand_path('../config/application', __dir__) | ||
| require_relative '../config/boot' | ||
| require 'rails/commands' | ||
| require_relative "../config/boot" | ||
| require "rails/commands" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/usr/bin/env ruby | ||
| require_relative '../config/boot' | ||
| require 'rake' | ||
| require_relative "../config/boot" | ||
| require "rake" | ||
| Rake.application.run |
Oops, something went wrong.