Justin/APPEALS-62255 #23469
Draft
Justin/APPEALS-62255 #23469
+223,439
−1,116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove redundant find_by's * removed comma * removed commas --------- Co-authored-by: HunJerBAH <[email protected]>
* Caceves/appeals 41709 v5 (#21878) * APPEALS-41709 - Uncorrupted Branch; First commit - Remove Columns from Correspondences * APPEALS-41709 - Drop package_document_types Table * Update remove * Updating Serializer for Correspondence * Removing portal_entry_date * Removing source_type * Removing cmp_packet_number * Removing cmp_queue_id * Removing package_document_type_id * package_document_type * Fix merge issues with table * Update Migration inheritance * Remove package_document_type from correspondence model * WIP working on safely removing old package document type * Restore queue_column * Restore correspondence_queue_column.rb * Restore client test correspondence.js * More package doc type removals * Remove unused package document type * Remove package document type and fix closing end statement * Remove package document type from spec * Fix 2 linter issues * Update queue_helpers to not use package_doc_type * Adjust docket_number & docket_name because was getting an error on the explain page * Fixed lint issue --------- Co-authored-by: KiMauVA <[email protected]> * Update migration to have safety assured * Siva-Khalin/Appeals 43239 (#21811) * Setting up skeleton for future ACs * #43239 - AC 2 * #43239 - create new route and verify access is added * #43239 - #AC2 added link to queue tab * AC1 WIP * Updating access_allowed method * WIP * #43239 - #AC4 added new correspondence_admin feature toggle * AC1 Done * #43239 - added AC5.1 and AC5.2 * #43239 - moved text to constants * AC 5 WIP * #43239 - added number field and submit button * #43239 - limiting veteran file numbers to 10 * AC 5 continued WIP * #43239 - CSS Updates * #43239 - AC 5.6.2 and AC 5.6.4 * file_number check method * invalid_file_num_error_message ruby Method * #43239 - correspondence controller specs * #43239 - removed unused code * Routes WIP * Get Correspondence Test Route Working * #43239 - generate correspondence route * #43239 - Added FE changes for success response * #43239 - removed correspondence size in the api response * Fix various minor rubocop offenses * WIP generate_correspondence * #47513 - Test Correspondence Jest Tests * #47518 - Generate Correspondence updates * #47518 #47512 - specs for BE methods * #43239 - lint * #41709 - removed columns * removed unused code * lint * lint fixes * revert Gemfile.lock --------- Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Alexander Smith <[email protected]> Co-authored-by: Christopher Aceves <[email protected]> Co-authored-by: cacevesva <[email protected]> Co-authored-by: psivakeshva <[email protected]> --------- Co-authored-by: KiMauVA <[email protected]> Co-authored-by: Dev-KRedd <[email protected]> Co-authored-by: psivakeshva <[email protected]> Co-authored-by: Alexander Smith <[email protected]> Co-authored-by: psivakeshva <[email protected]>
* Removing requirement for correspondence_type_id to be assigned * removing correspondence_type_id from being built in seeds files in queue_helpers
Co-authored-by: HunJerBAH <[email protected]>
* comment for source change to register * refactored appeals_controller to use params safely. regression test clean. * untested correspondence_controller params change. * refactored correspondence_document_controller. regression tested. * refactored unsafe params. regression tested. * removed shared params inside concern (bad practice) * refactored param safety. regression tested. * refactored unsafe code. manually tested * refactored params to be secure. regression tested. * broke params into multiple lines * refactored missing params into secure ones. regression tested again. * refactored potential incorrect param * minor param refactor. * removed binding.pry and updated params.permit. regression tested again. * fixed param issue * updated params.permit * fixed params issue * another param fix * second attempted fix * might have actually fixed it * another fix attempt * fixed linting issues * removed unused default params * fixed rubocop complains with helper methods * changed helper methods to be a constant * moved pdf_params into separate method in correspondence_review_package_controller --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: HunJerBAH <[email protected]>
* #44296 - Updated labels * #44296 - Updated specs * #44296 - Updated labels to sync with every other label in file
* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * Spec fixes for single and multiple batch assignment * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * made changes to grammar and updated unit tests to match * refactored banner logic to let auto user finder be the source of truth for assignment errors * refactored logger to log the most recent unassignable reason from the auto assign user finder. * fixed linting errors --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]>
…kage modal on Review Package form (#21964) * initial commit * added .match.params to handle history props in QueueApp routing * displaying banners for the correspondence review package actions * Removing debugger * removing the comment --------- Co-authored-by: HunJerBAH <[email protected]>
* Passing rspec tests * correspondence_review_package_controller_spec.rb fix * Fixing checkbox test spec
* Initial commit for multiple assignement * Provided the conditional logic for single and multiple * Updated the error message * changed the way errors are gathered * Modified the text message to display * Line break fix * changed messages so they only populate if there are errors * removed unless statement * Modified the code changes to fix rubocop issues * added back return false statement * adjusted display of bullet points * Modified the code due to rubocop fixes * updating failed assignment header texts * Spec fixes for single and multiple batch assignment * updating failed assignment reason errors * updating tests to pass with new messages * removed commented code. * Moved the constants to constant file * Modified the constants file to a new file * Changing the banner text method name to match incoming changes from feature * adding build method for single error message * fixing a mistake in my switch case code * Fixing up some reasons for single errors * correcting capacity error wording from multiple assignments ticket * adding "to user" text and matching messages across single and multiple assignment errors * Updating comments and spacing for code readability * Reverting to feature from tests because of wacky failures * updating mail team user to inbound ops team user in test descriptions * updating single assignment and batch assignment tests to match new labels * removing deprecated methods * fixed linting errors --------- Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: Ryan Marshall <[email protected]> Co-authored-by: divyadasari-va <[email protected]> Co-authored-by: HunJerBAH <[email protected]>
#21939) * APPEALS-48218 - edit_cmp_information_rspec Updates * #48582 - Corrected test data and added initial states * APPEALS-48218 - CodeClimate Updates * APPEALS-48218 - CodeClimate Updates * Lint * Linting * CC Updates --------- Co-authored-by: psivakeshva <[email protected]>
…or does not show (#22029) * fixing an accidental bug where a bullet point containing a single error does not show * updating name
* CodeClimate TL Approved Comments * CodeClimate Updates 2 * Reek Update * Reek 2
…ment Type (#22019) * update nod * update nod * push up changes for nod * update parameters for create_correspondence_document * remove method --------- Co-authored-by: HunJerBAH <[email protected]>
* renaming previous method that runs for each user * Creating appeals for our veterans in the create_veterans file * editing the inactive appeals for users to create 3 of each type at the beginning of the list * Minor edit to some code comments * code climate fix --------- Co-authored-by: cacevesva <[email protected]>
* Added feature test for docketswitchmailtask * Added test case testing for appropriate task assignor and assignee
* update restrictions to add task * update check_inbound_ops_team_user method * update specs * update specs
* Add feature test setup for all inactive appeal tasks * Deepak/appeals 56223 (#23310) * update restrictions to add task * update check_inbound_ops_team_user method * update specs * update specs * test for creation & association of task objs * remove comment * refactor and add more test checks * feature test updates * combined into one it block to speed up testing * Add BvaDispatch task exception * correct conditional stmt * added retry helper method when element not found * Wrap flaky portion of test in retry block * define action in method * add logging to retry * update test --------- Co-authored-by: SanthiParakal133 <[email protected]>
…AH/APPEALS-34965-merge-conflicts Feature/APPEALS-34965: resolved merge conflicts from Main
* rename variable * Refactored to use existing module
|
Code Climate has analyzed commit 1e4fbb7 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Fix/Adjust Failing Correspondence Related Tests for Correspondence Details Page
Description
Spec test fixing for APPEALS-34965 (built from APEALS-39909)
Acceptance Criteria
Testing Plan