Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-need-help: align header font-size with Figma #1520

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Mar 10, 2025

Chromatic

https://3655-need-help-header--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

Figma is showing the header font size as 20px/1.25rem so this will update it to use the corresponding header token. There is a slight decrease in font size which is expected.

Closes department-of-veterans-affairs/vets-design-system-documentation#3655

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

before

Screenshot 2025-03-10 at 4 44 27 PM

after

Screenshot 2025-03-10 at 4 44 35 PM

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue

@jamigibbs jamigibbs added the patch Patch change in semantic versioning label Mar 10, 2025
@jamigibbs jamigibbs marked this pull request as ready for review March 10, 2025 21:56
@jamigibbs jamigibbs requested a review from a team as a code owner March 10, 2025 21:56
@jamigibbs jamigibbs merged commit 40afe08 into main Mar 11, 2025
8 checks passed
@jamigibbs jamigibbs deleted the 3655-need-help-header branch March 11, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Need help" component heading is sized with ems
2 participants