Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: update background color for the use with caution label #1521

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Mar 11, 2025

Chromatic

https://storybook-maturity-label--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

This fixes an issue where we lost the maturity color for the warning label. The colors were selected based on the maturity scale here: https://design.va.gov/about/maturity-scale

Screenshots

before

Screenshot 2025-03-11 at 9 49 33 AM

after

Screenshot 2025-03-11 at 10 05 53 AM

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue

@jamigibbs jamigibbs added the ignore-for-release Used if you want to ignore the PR in the generated release notes label Mar 11, 2025
@jamigibbs jamigibbs marked this pull request as ready for review March 11, 2025 15:12
@jamigibbs jamigibbs requested a review from a team as a code owner March 11, 2025 15:12
@jamigibbs jamigibbs merged commit d632b3a into main Mar 11, 2025
8 checks passed
@jamigibbs jamigibbs deleted the storybook-maturity-label branch March 11, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Used if you want to ignore the PR in the generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants