Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds registry entry for new form app (21-4140). #2346

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ryguyk
Copy link
Contributor

@ryguyk ryguyk commented Nov 6, 2024

DO NOT MERGE
Must merge vets-website PR first.

Summary

Adds an entry to registry.json for a new app added in vets-website (simple-forms-form-engine/21-4140).

Related issue(s)

Original ticket: department-of-veterans-affairs/va.gov-team#96075
vets-website PR with added app: department-of-veterans-affairs/vets-website#32891

Testing done

N/A. Simply a registry addition.

Screenshots

N/A

What areas of the site does it impact?

Simply a registry addition.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

N/A

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/21-4140-ehq November 6, 2024 22:19 Inactive
Copy link
Contributor

@derekhouck derekhouck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving now so it can be merged once the other PR is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants