Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appName to correct title for Authenticated Experience Design Patterns #2353

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update appName to correct title for Authenticated Experience Design Patterns #2353

wants to merge 2 commits into from
+1 −1

Conversation

adamwhitlock1
Copy link
Contributor

Summary

  • Changes the appName so that it is read correctly by screen readers.

Related issue(s)

Testing done

  • Tested locally to verify that app title appears in browser tab correctly and is read by screen reader

Screenshots

No UI changes

What areas of the site does it impact?

Authenticated Experience Design Patterns mock form app. No changes being shipped to prod

Acceptance criteria

Title updated

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

@adamwhitlock1 adamwhitlock1 requested review from a team as code owners November 13, 2024 16:36
@adamwhitlock1 adamwhitlock1 marked this pull request as draft November 13, 2024 16:37
@adamwhitlock1 adamwhitlock1 marked this pull request as ready for review November 13, 2024 16:39
bellepx0
bellepx0 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@bellepx0 bellepx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellepx0 bellepx0 bellepx0 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwhitlock1 @bellepx0 @va-vfs-bot