Don't retry 404s #899
Open
Don't retry 404s #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseek
reviewed
Mar 10, 2025
| @@ -87,7 +87,7 @@ export const getFetcher = ( | |||
| // In non-debug mode: only on final attempt | |||
| const logFailedRequest = debug ? true : attempt === retryCount + 1 | |||
|
|
|||
| if (!response.ok) { | |||
| if (!response.ok && response.status !== 404) { | |||
There was a problem hiding this comment.
Unless I'm reading this wrong, this still retries 404, it just doesn't log them. Is that the intent?
There was a problem hiding this comment.
If we wanted to abort for 404, on the next line change it to be if (logFailedRequest || response.status === 404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
proxy-fetchgets a non-ok response, it retries up to 5 times (total of 6 attempts). This doesn't make sense when the response is a 404 error.