Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16756 Staff profile layout #917

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Mar 4, 2025

Description

This PR adds the staff profile layout and updates the query that pulls in the person_profile data that this layout uses.

Ticket

#16756

Developer Task

- [x] PR submitted against the `main` branch of `next-build`.
- [x] Link to the issue that this PR addresses (if applicable).
- [ ] Define all changes in your PR and note any changes that could potentially be breaking changes.
- [ ] PR includes steps to test your changes and links to these changes in the Tugboat preview (if applicable).
- [ ] Provided before and after screenshots of your changes (if applicable).
- [ ] Alerted the #accelerated-publishing Slack channel to request a PR review.
- [ ] You understand that once approved, you are responsible for merging your changes into `main`. (Note that changes to `main` will move automatically into production.)

Testing Steps

Tested locally at http://localhost:3999/pittsburgh-health-care/staff-profiles/prachi-asher/

Navigate to any staff profile page and verify that the layout is pulling in data and rendering successfully.

QA steps

What needs to be checked to prove this works?
Need to verify that data and formatting matches prod.

What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Screenshots

Before :
Prachi_Asher___VA_Pittsburgh_Health_Care___Veterans_Affairs

After:
Prachi_Asher___VA_Pittsburgh_health_care___Veterans_Affairs

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

- [ ] Code Quality: Readabilty, Naming Conventions, Consistency, Reusability
- [ ] Test Coverage: 80% coverage
- [ ] Functionality: Change functions as expected with no additional bugs
- [ ] Performance: Code does not introduce performance issues
- [ ] Documentation: Changes are documented in their respective README.md files
- [ ] Security: Packages have been approved in the TRM

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 02:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 03:05 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 03:07 Destroyed
@chriskim2311 chriskim2311 marked this pull request as ready for review March 4, 2025 16:52
@chriskim2311 chriskim2311 requested review from a team as code owners March 4, 2025 16:52
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 18:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 21:32 Destroyed
Chris Kim added 2 commits March 4, 2025 15:42
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2025 23:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 00:16 Destroyed
Chris Kim added 2 commits March 4, 2025 16:19
…-veterans-affairs/next-build into 16756-staff-profile-layout
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 00:20 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 00:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 17:22 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 17:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 18:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 18:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 23:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 23:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2025 23:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 7, 2025 20:52 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 10, 2025 18:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 11, 2025 05:09 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 11, 2025 05:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 11, 2025 15:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 11, 2025 17:00 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 11, 2025 17:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 11, 2025 18:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 12, 2025 03:51 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants