Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/9452-ClaimFileUploadEmbeddedScreens #10054

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

alexandec
Copy link
Contributor

@alexandec alexandec commented Oct 29, 2024

Description of Change

Modify the Claim File Request and Submit Evidence flows to function as nested child screens inside a single FullScreenSubtask. This PR creates a new pattern we can use for any similar multi-step subtask.

PR includes:

  • Creation of a new MultiStepSubtask template which wraps FullScreenSubtask
  • Creation of a UseSubtaskProps hook and associated context allowing child screens to set props on the parent FullScreenSubtask (buttons, etc)
  • Accommodation of shared screens between the File Request and Submit Evidence nav stacks

Screenshots/Video

File Request Before:

original.mp4

File Request After:

refactored-title.mp4

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

  • Coordinate with/bring in the @liztownd work done on the top part of the Travel Pay subtask screen flow. She has a successful solution within this flow.
  • Copy the behavior within Messages > Start new message
  • “Freeze” top nav bar, so that screen content changes between screens, but top nav appears fixed. (See behavior on first screen on scroll)
  • VQA with designer (approval in Slack thread)

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@alexandec alexandec marked this pull request as ready for review October 31, 2024 22:57
@alexandec alexandec requested review from a team as code owners October 31, 2024 22:57
Sparowhawk
Sparowhawk previously approved these changes Nov 5, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE-With QA A PR waiting for QA Activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants