Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/9900-ClaimFileRequestBottomSpacing #10127

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

bug/9900-ClaimFileRequestBottomSpacing #10127

wants to merge 3 commits into from
+12 −3

Conversation

alexandec
Copy link
Contributor

Description of Change

Add missing spacing on "Submit file" button (claim file upload).

Screenshots/Video

Before/after:
  

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Claim file request submit buttons have proper spacing

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@alexandec alexandec requested review from a team as code owners November 6, 2024 19:26
dumathane
dumathane previously approved these changes Nov 7, 2024
View reviewed changes
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumathane dumathane dumathane left review comments

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
FE-With QA A PR waiting for QA Activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandec @dumathane