Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/10115-VALogoResizing #10143

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

bug/10115-VALogoResizing #10143

wants to merge 1 commit into from

Conversation

Sparowhawk
Copy link
Contributor

Description of Change

Found out the issue was the hard set width of 254 was cutting off the s, so I bumped it to 270 and it is no longer cut off.

Screenshots/Video

Screenshot 2024-11-07 at 1 51 55 PM

Testing

yarn test

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Space is extended, so there is no more cutoff
Nothing else is affected (a11y stays the same, etc)
VQA with any designer

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@Sparowhawk Sparowhawk requested review from a team as code owners November 7, 2024 19:56
@Sparowhawk Sparowhawk changed the title finished bug/10115-VALogoResizing Nov 7, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumathane dumathane dumathane approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-With QA A PR waiting for QA Activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sparowhawk @dumathane