bug/9392-rachael-detox-run-for-dependabots-v2 #10144
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbontrager
requested review from
timwright12,
alexandec,
theodur,
dumathane,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
theodur
reviewed
Nov 14, 2024
| @@ -98,8 +98,8 @@ jobs: | |||
| - name: 'Get Matrix Value' | |||
| id: matrix_value | |||
| run: | | |||
| if [[ "${{ inputs.run_full_test }}" == "true" ]] || [[ ${{ github.event_name }} == 'schedule' ]] || [[ "${{ inputs.tests_to_run}}" != "" ]] || [[ "${{ github.event.pull_request.user.login }}" == "dependabot[bot]" ]]; then | |||
| if [[ "${{ inputs.run_full_test }}" == "true" ]] || [[ ${{ github.event_name }} == 'schedule' ]] || [[ "${{ github.event.pull_request.user.login }}" == "dependabot[bot]" ]]; then | |||
| if [[ "${{ inputs.run_full_test }}" == "true" ]] || [[ ${{ github.event_name }} == 'schedule' ]] || [[ "${{ inputs.tests_to_run}}" != "" ]] || [[ "${{ github.event.push.actor.login }}" == "dependabot[bot]" ]]; then | |||
There was a problem hiding this comment.
This will only work when Dependabot initially opens the PR, but won't work for subsequent commits to the branch made by other people.
Instead of updating this, I think the paths in the pull_request trigger need to be updated to include VAMobile/package.json. Then the [[ "${{ github.event.pull_request.user.login }}" == "dependabot[bot]" ]] logic should be true whenever a commit by anyone is pushed to a Dependabot branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
2nd try for adding the dependabot to detox runs...
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch