Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/10135-FixVABulletContrastColors #10146

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sparowhawk
Copy link
Contributor

@Sparowhawk Sparowhawk commented Nov 7, 2024

Description of Change

Updated VABulletList color to match text color for the onboarding screens and any other instances of it being on top of the blue background

Screenshots/Video

Dark and Light mode
Screenshot 2024-11-07 at 2 21 40 PM
Screenshot 2024-11-07 at 2 21 45 PM

Testing

yarn test

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Confirmed that dark mode has white bullet points (aka sufficient contrast) and that this is new in this release. I'm guessing it was caused by the icon conversion (ticket 9779).

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@Sparowhawk Sparowhawk requested review from a team as code owners November 7, 2024 20:23
@Sparowhawk Sparowhawk changed the title updated bug/10135-FixVABulletContrastColors Nov 7, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 12, 2024
Copy link
Contributor

@theodur theodur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sparowhawk Just realized I committed a fix for this in #9199. I was going to revert that commit and just let this PR fix the issue as Therese pointed out this PR, but I forgot to revert that commit from my branch. So this PR isn't needed anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE-With QA A PR waiting for QA Activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants