Spike binny in app feedback #10166
Open
Spike binny in app feedback #10166
+183
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumathane
commented
Nov 13, 2024
| // satisfaction, | ||
| // }, | ||
| // } | ||
| // }, |
There was a problem hiding this comment.
Committing these analytics commented out for the other ticket to provide.
dumathane
requested review from
timwright12,
alexandec,
theodur,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
alexandec
requested changes
Nov 14, 2024
| </Box> | ||
| <Box | ||
| borderTopWidth={theme.dimensions.borderWidth} | ||
| borderColor={theme.colors.border.prescriptionDivider as BorderColorVariant}> |
There was a problem hiding this comment.
Should this color be renamed if it's used in multiple places?
| "inAppFeedback.popup.title": "Leave feedback?", | ||
| "inAppFeedback.popup.body": "Leaving us feedback helps us improve.", | ||
| "inAppFeedback.popup.notNow": "Not now", | ||
| "inAppFeedback.popup.accept": "Give feedback", |
There was a problem hiding this comment.
Instead of adding this translation twice, you could add it once with giveFeedback as the key
| "inAppFeedback.a11yHint": "Go to the give feedback page", | ||
| "inAppFeedback.popup.title": "Leave feedback?", | ||
| "inAppFeedback.popup.body": "Leaving us feedback helps us improve.", | ||
| "inAppFeedback.popup.notNow": "Not now", |
There was a problem hiding this comment.
This could just use 'notNow' as the key
| "inAppFeedback.legalReqs.number": "OMB Number: 2900-0876", | ||
| "inAppFeedback.legalReqs.expiration": "Expiration: 02/28/2026", | ||
| "inAppFeedback.legalReqs.burdenTime": "Burden Time: 3 Minutes", | ||
| "inAppFeedback.legalReqs.paragraph": "VA may utilize individual Veteran survey data from this survey or other sources to ensure the final scores truly and accurately represent the experiences of Veterans. This information is collected in accordance with section 3507 of the Paperwork Reduction Act of 1995. Title 38, United States Code, allows us to ask for this information. We estimate that you will need an average of 3 minutes to review the instructions and complete this survey. The results of this survey will be used to inform opportunities for program improvement in the quality of VA services. Participation in this survey is voluntary, and your decision not to respond will have no impact on VA benefits or services which you may currently be receiving. VA cannot conduct or sponsor a collection of information unless a valid OMB control number is displayed. You are not required to respond to a collection of information if this number is not displayed. Valid OMB control numbers can be located on the OMB Internet Page at https://www.reginfo.gov/public/do/PRAMain. Information gathered will be kept private to the extent provided by law.", |
There was a problem hiding this comment.
Should the link be clickable?
| isTextArea={true} | ||
| value={task} | ||
| testID="AppFeedbackTaskID" | ||
| onChange={(val) => { |
There was a problem hiding this comment.
Can probably simplify to onChange={setTaskOverride}
|
|
||
| const radioGroupProps: RadioGroupProps<string> = { | ||
| isRadioList: false, | ||
| onChange: onChange, |
There was a problem hiding this comment.
This can probably just be onChange: setSatisfaction
| @@ -257,6 +257,28 @@ export function useExternalLink(): (url: string, eventParams?: EventParams) => v | |||
| } | |||
| } | |||
|
|
|||
| export function useGiveFeedback(): (task: string) => void { | |||
There was a problem hiding this comment.
Consider creating a constant to collect all the possible values in one place
| @@ -202,6 +208,9 @@ function DeveloperScreen({ navigation }: DeveloperScreenSettingsScreenProps) { | |||
| </TextView> | |||
| </Box> | |||
| </TextArea> | |||
| <TextArea> | |||
| <Button onPress={onFeedback} label={'In App Feedback Screen'} /> | |||
There was a problem hiding this comment.
Does this need a translation?
github-actions
bot
added
the
FE-Changes Requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Screenshots/Video
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch