Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/9996-Usei18nInUnitTests-Home-4 #10193

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

chore/9996-Usei18nInUnitTests-Home-4 #10193

wants to merge 2 commits into from
+70 −73

Conversation

ATeal
Copy link
Contributor

@ATeal ATeal commented Nov 14, 2024

Description of Change

Update the unit test in #9996 to use 18n

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@ATeal ATeal requested review from a team as code owners November 14, 2024 20:05
@ATeal ATeal changed the title jchore: update personal info screen tests with i18n chore/9996-Usei18nInUnitTests-Home-4 Nov 14, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Nov 14, 2024
@theodur theodur added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodur theodur theodur approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ATeal @theodur