Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU/10187-Chika-AddBackAnnouncementForScreenreaderUsers #10314

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

cadibemma
Copy link
Contributor

@cadibemma cadibemma commented Dec 4, 2024

Description of Change

  • Adds an accessibility label to read out prior to the "back" link's copy. For example, the screenreaders should announce "back to benefits, link" or "back to health, link"

Screenshots/Video

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

  • Add an accessibility label of "back to" that reads out before the current / existing readout on the child screen links
  • Send to @brea11y for review

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@cadibemma cadibemma marked this pull request as ready for review December 5, 2024 01:13
@cadibemma cadibemma requested review from a team as code owners December 5, 2024 01:13
dumathane
dumathane previously approved these changes Dec 5, 2024
@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Dec 5, 2024
@cadibemma cadibemma linked an issue Dec 6, 2024 that may be closed by this pull request
2 tasks
@cadibemma cadibemma requested a review from brea11y December 8, 2024 06:16
brea11y
brea11y previously approved these changes Dec 13, 2024
@cadibemma cadibemma dismissed stale reviews from brea11y and dumathane via 7a94561 December 13, 2024 20:00
@github-actions github-actions bot added FE-Ready to Merge and removed FE-With QA A PR waiting for QA Activity labels Dec 13, 2024
@cadibemma cadibemma merged commit 2936abd into develop Dec 13, 2024
79 of 82 checks passed
@cadibemma cadibemma deleted the 10187-add-back-announcement-for-screenreader branch December 13, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "back" announcement for screenreader users
4 participants