-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spike/9918-rachael-detox-add-what-to-run-to-code #9919
Open
rbontrager
wants to merge
126
commits into
develop
Choose a base branch
from
spike/9918-rachael-detox-add-what-to-run-to-code
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
spike/9918-rachael-detox-add-what-to-run-to-code #9919
rbontrager
wants to merge
126
commits into
develop
from
spike/9918-rachael-detox-add-what-to-run-to-code
+477
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbontrager
requested review from
timwright12,
alexandec,
theodur,
dumathane,
cadibemma,
Sparowhawk and
DonMcCaugheyUSDS
November 12, 2024 19:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The detox mapping file was always getting out of date/had multiple misspellings that was causing it to not run the correct files when it should. To combat this I've reduced the numbers of files specifically checked as much as possible and added more encompassing directory checks. I've also add jobs that will check that files/directories changed are in detox mapping file, that the directory/file names are spelled correctly, and that the e2eNames are spelled correctly. If any of these jobs fail find_detox_tests_to_run will fail and cause the e2e_android test to fail and appear as a failure in the PR check.
Screenshots/Video
Running test: https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/11798447379
Misspelled e2eNames
Misspelled directoryNames
Testing
Reviewer Validations
PR Checklist
Reviewer: Confirm the items below as you review
For QA
Run a build for this branch