Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike/9918-rachael-detox-add-what-to-run-to-code #9919

Open
wants to merge 126 commits into
base: develop
Choose a base branch
from

Conversation

rbontrager
Copy link
Contributor

@rbontrager rbontrager commented Oct 18, 2024

Description of Change

The detox mapping file was always getting out of date/had multiple misspellings that was causing it to not run the correct files when it should. To combat this I've reduced the numbers of files specifically checked as much as possible and added more encompassing directory checks. I've also add jobs that will check that files/directories changed are in detox mapping file, that the directory/file names are spelled correctly, and that the e2eNames are spelled correctly. If any of these jobs fail find_detox_tests_to_run will fail and cause the e2e_android test to fail and appear as a failure in the PR check.

Screenshots/Video

Running test: https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/11798447379

Misspelled e2eNames
e2eNamesMisspelled

Misspelled directoryNames
DirectoryNameMisspelled

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant