Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Drupal UX for Staff Profile, VAMC Billing & Insurance, VAMC Facility mental health phone number #19512

Open
1 task done
davidmpickett opened this issue Oct 15, 2024 · 7 comments
Labels
current sprint Drupal engineering CMS team practice area Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) ghp-refine points-5 sitewide UX VAMC CMS managed product owned by Facilities team

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Oct 15, 2024

[2024-10-16] Not blocking shipping CMS changes behind a toggle, but IS launch blocking for change management / editor comms.

Description

These three content types are changing from a single non-required field to a paragraph type for phone number entry

  • Staff Profile
  • VAMC System Billing & Insurance
  • VAMC Facility - (Mental Health Phone Number)

Current UX quirks

When a phone number has been added, it's not immediately clear how to remove it. There's also a bunch of irrelevant options in the menus like Collapse and Drag & Drop. We also repeat the "phone number" title.

Image

When no phone number has been added there's a weird gap with a bullet point in it. And there's the awkward phrase "add phone number to phone number"

Image

Change log

  • Staff Profile now defaults to no phone number (but can be manually added)
  • The widget for all three content types has changed from Paragraphs Stable to Paragraphs Legacy
State Current UI New UI
No phone number added Image Screenshot 2024-10-24 at 5 16 25 PM
With phone number added Screenshot 2024-10-24 at 5 19 03 PM Screenshot 2024-10-24 at 5 31 56 PM

Acceptance criteria

ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable.

  • Implement new interface for each Content Type
@davidmpickett davidmpickett changed the title Default Drupal UX for Staff Profile, VAMC Billing & Insurance, VAMC Facility mental health phone number Drupal UX for Staff Profile, VAMC Billing & Insurance, VAMC Facility mental health phone number Oct 15, 2024
@davidmpickett davidmpickett added Facilities Facilities products (VAMC, Vet Center, etc) VAMC CMS managed product owned by Facilities team UX labels Oct 15, 2024
@jilladams
Copy link
Contributor

In sprint 15: Jordan may not have time to address before Dave is back from PTO

The conversation from scrum: https://dsva.slack.com/archives/C079GFKN50D/p1729007496363379?thread_ts=1728955309.898119&cid=C079GFKN50D

Staff Profile = guess: ~75% of those have #s
Mental Health Phone = should feel required (or be required)
Billing & Ins = need to audit to know which way to handle

All 3 don't have to act the same.

This does not block merging existing phone # work to prod behind the feature toggle.

@jilladams
Copy link
Contributor

Pointing as a 5 based on Jordan's level of familiarity. May be lower if Dave picks it up.

@davidmpickett
Copy link
Contributor Author

@jilladams Is this in Sprint or Needs refinement?

@davidmpickett davidmpickett self-assigned this Oct 23, 2024
@davidmpickett
Copy link
Contributor Author

davidmpickett commented Oct 23, 2024

WIP notes to self

VAMC System Billing & Insurance

Image

VAMC Facility - (Mental Health Phone Number)

Staff profile

@davidmpickett davidmpickett removed the Needs refining Issue status label Oct 23, 2024
@davidmpickett
Copy link
Contributor Author

I think the solution is gonna be switching to Paragraphs Legacy widget

Image
Image

@davidmpickett davidmpickett changed the title Drupal UX for Staff Profile, VAMC Billing & Insurance, VAMC Facility mental health phone number Improve Drupal UX for Staff Profile, VAMC Billing & Insurance, VAMC Facility mental health phone number Oct 25, 2024
@davidmpickett davidmpickett added the Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding label Oct 25, 2024
@davidmpickett
Copy link
Contributor Author

End of Sprint update

  • PR has ✅ code review and ✅ UX review (slack thread)
  • Waiting to hear from @laflannery if a11y review is needed
  • Other than that ready to merge & verify

@davidmpickett
Copy link
Contributor Author

Update

  • I have moved this back to In Progress to incorporate @laflannery's notes in the PR
  • Because the new scope of Laura's edits require modifying the SCSS, I am also gonna fix the Truncated textissue @jilladams caught
  • Will need to go through testing and code review again & now need review by CMS platform team

@jilladams jilladams added the Drupal engineering CMS team practice area label Nov 7, 2024
@davidmpickett davidmpickett removed their assignment Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current sprint Drupal engineering CMS team practice area Drupal Site Building For tasks that involve updating Drupal config, but don't involve significant coding Facilities Facilities products (VAMC, Vet Center, etc) ghp-refine points-5 sitewide UX VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

2 participants