Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19821: Removes mental health number from Facility IEF #19822

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Nov 6, 2024

Description

Relates to #19821

Testing done

Manually

Screenshots

Screenshot 2024-11-06 at 5 00 31 PM

QA steps

Set up editor

  1. Log in as an admin
  • Assign the user QA Content Publisher to the "VA Boston health care" Section
  • Assign the following roles to QA Content Publisher
    • Content publisher
    • Content creator - VAMC

Review the operating status

  1. Log in as QA Content Publisher
  2. Edit the Operating status | VA Boston health care page
  3. Scroll down to the Facility operating statuses
  4. Click on the Edit of the first facility
  • Confirm that no "Mental health phone number" is shown

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@omahane omahane requested a review from a team as a code owner November 6, 2024 23:01
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 6, 2024 23:01 Destroyed
Copy link

github-actions bot commented Nov 6, 2024

Checking composer.lock changes...

jv-agile6
jv-agile6 previously approved these changes Nov 7, 2024
Copy link
Contributor

@jv-agile6 jv-agile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed QA test steps to success. Reviewed the Facility operating statuses to determind there was no mental health phone field. Reviewed configuration changes, and approved.

@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Nov 7, 2024
@@ -53,7 +51,6 @@ third_party_settings:
group_editorial_workflow:
children:
- moderation_state
- revision_log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revision log should not be removed @omahane.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore this comment. IEF widget doesn't show this anyway, so it probably doesn't matter

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 7, 2024 09:00 Destroyed
@davidmpickett
Copy link
Contributor

Works as intended. Approved.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 7, 2024 17:23 Destroyed
Copy link

github-actions bot commented Nov 7, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 7, 2024 17:24 Destroyed
Copy link

github-actions bot commented Nov 7, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 8, 2024 17:14 Destroyed
Copy link

github-actions bot commented Nov 8, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 8, 2024 18:48 Destroyed
Copy link
Contributor

@jv-agile6 jv-agile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed updated changes to core.entity_form_display.node.health_care_local_facility.inline_entity_form.yml and approved.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 8, 2024 22:41 Destroyed
Copy link

github-actions bot commented Nov 8, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 9, 2024 09:01 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 10, 2024 08:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 11, 2024 08:52 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 12, 2024 08:55 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 12, 2024 13:47 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Accessibility Violations Found:

[
  {
    "route": "/test-data-molestiae",
    "id": "button-name",
    "impact": "critical",
    "tags": [
      "cat.name-role-value",
      "wcag2a",
      "wcag412",
      "section508",
      "section508.22.a",
      "ACT",
      "TTv5",
      "TT6.a"
    ],
    "description": "Ensures buttons have discernible text",
    "help": "Buttons must have discernible text",
    "helpUrl": "https://dequeuniversity.com/rules/axe/4.7/button-name?application=axeAPI",
    "nodes": [
      {
        "any": [
          {
            "id": "button-has-visible-text",
            "data": null,
            "relatedNodes": [],
            "impact": "critical",
            "message": "Element does not have inner text that is visible to screen readers"
          },
          {
            "id": "aria-label",
            "data": null,
            "relatedNodes": [],
            "impact": "serious",
            "message": "aria-label attribute does not exist or is empty"
          },
          {
            "id": "aria-labelledby",
            "data": null,
            "relatedNodes": [],
            "impact": "serious",
            "message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
          },
          {
            "id": "non-empty-title",
            "data": {
              "messageKey": "noAttr"
            },
            "relatedNodes": [],
            "impact": "serious",
            "message": "Element has no title attribute"
          },
          {
            "id": "presentational-role",
            "data": null,
            "relatedNodes": [],
            "impact": "minor",
            "message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
          }
        ],
        "all": [],
        "none": [],
        "impact": "critical",
        "html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Page introduction' field\" data-proofing-help=\"Add an introduction that helps visitors understand if information on the page is relevant to them.\">
          <span aria-hidden=\"true\">i</span>
        </button>",
        "target": [
          ".field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role=\"tooltip\"]"
        ],
        "failureSummary": "Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
      },
      {
        "any": [
          {
            "id": "button-has-visible-text",
            "data": null,
            "relatedNodes": [],
            "impact": "critical",
            "message": "Element does not have inner text that is visible to screen readers"
          },
          {
            "id": "aria-label",
            "data": null,
            "relatedNodes": [],
            "impact": "serious",
            "message": "aria-label attribute does not exist or is empty"
          },
          {
            "id": "aria-labelledby",
            "data": null,
            "relatedNodes": [],
            "impact": "serious",
            "message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
          },
          {
            "id": "non-empty-title",
            "data": {
              "messageKey": "noAttr"
            },
            "relatedNodes": [],
            "impact": "serious",
            "message": "Element has no title attribute"
          },
          {
            "id": "presentational-role",
            "data": null,
            "relatedNodes": [],
            "impact": "minor",
            "message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
          }
        ],
        "all": [],
        "none": [],
        "impact": "critical",
        "html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Generate a table of contents from major headings' field\" data-proofing-help=\"By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.\">",
        "target": [
          ".field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role=\"tooltip\"]"
        ],
        "failureSummary": "Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
      },
      {
        "any": [
          {
            "id": "button-has-visible-text",
            "data": null,
            "relatedNodes": [],
            "impact": "critical",
            "message": "Element does not have inner text that is visible to screen readers"
          },
          {
            "id": "aria-label",
            "data": null,
            "relatedNodes": [],
            "impact": "serious",
            "message": "aria-label attribute does not exist or is empty"
          },
          {
            "id": "aria-labelledby",
            "data": null,
            "relatedNodes": [],
            "impact": "serious",
            "message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
          },
          {
            "id": "non-empty-title",
            "data": {
              "messageKey": "noAttr"
            },
            "relatedNodes": [],
            "impact": "serious",
            "message": "Element has no title attribute"
          },
          {
            "id": "presentational-role",
            "data": null,
            "relatedNodes": [],
            "impact": "minor",
            "message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
          }
        ],
        "all": [],
        "none": [],
        "impact": "critical",
        "html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Main content' field\" data-proofing-help=\"The main body of the page, which appears below the featured content.\">
          <span aria-hidden=\"true\">i</span>
        </button>",
        "target": [
          "button[data-proofing-help-title=\"About 'Main content' field\"]"
        ],
        "failureSummary": "Fix any of the following:
  Element does not have inner text that is visible to screen readers
  aria-label attribute does not exist or is empty
  aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  Element has no title attribute
  Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
      }
    ]
  }
]

@omahane omahane merged commit 2547fde into main Nov 12, 2024
18 checks passed
@omahane omahane deleted the VACMS-19821-mental-health-phone-facility-ief branch November 12, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants