Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19773: update drupal core to v1038 #19873

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

JakeBapple
Copy link
Contributor

Description

Relates to #19773

Testing done

Local testing and content generation

QA steps

What needs to be checked to prove this works?
Look at composer file to core-recommended and core-scaffold is up to 10.3.8
What needs to be checked to prove it didn't break any related things?
Spot check pages to make sure nothing is broken.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@JakeBapple JakeBapple added the CMS Team CMS Product team that manages both editor exp and devops label Nov 14, 2024
@JakeBapple JakeBapple self-assigned this Nov 14, 2024
@JakeBapple JakeBapple requested review from a team as code owners November 14, 2024 17:11
@JakeBapple JakeBapple linked an issue Nov 14, 2024 that may be closed by this pull request
2 tasks
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 14, 2024 17:11 Destroyed
Copy link

Checking composer.lock changes...

Copy link

The number of lines changed in composer.lock exceeds the acceptable threshold.

  • Lines changed: 236
  • Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 15, 2024 09:08 Destroyed
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 15, 2024 15:49 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 16, 2024 08:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 17, 2024 08:55 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 18, 2024 08:57 Destroyed
@va-cms-bot
Copy link
Collaborator

Accessibility Violations Found:

[
  {
    "route": "/user/5283",
    "id": "color-contrast",
    "impact": "serious",
    "tags": [
      "cat.color",
      "wcag2aa",
      "wcag143",
      "ACT",
      "TTv5",
      "TT13.c"
    ],
    "description": "Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds",
    "help": "Elements must meet minimum color contrast ratio thresholds",
    "helpUrl": "https://dequeuniversity.com/rules/axe/4.7/color-contrast?application=axeAPI",
    "nodes": [
      {
        "any": [
          {
            "id": "color-contrast",
            "data": {
              "fgColor": "#dddddd",
              "bgColor": "#ffffff",
              "contrastRatio": 1.35,
              "fontSize": "19.2pt (25.632px)",
              "fontWeight": "bold",
              "messageKey": null,
              "expectedContrastRatio": "3:1"
            },
            "relatedNodes": [
              {
                "html": "<div id=\"toolbar-item-administration-tray\" data-toolbar-tray=\"toolbar-item-administration-tray\" class=\"toolbar-tray toolbar-tray-horizontal is-active\" data-offset-top=\"\">",
                "target": [
                  "#toolbar-item-administration-tray"
                ]
              }
            ],
            "impact": "serious",
            "message": "Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
          }
        ],
        "all": [],
        "none": [],
        "impact": "serious",
        "html": "<h3 class=\"toolbar-tray-name visually-hidden\">Administration menu</h3>",
        "target": [
          "nav[aria-label=\"Administration menu\"] > h3"
        ],
        "failureSummary": "Fix any of the following:
  Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
      }
    ]
  },
  {
    "route": "/node/add/basic_landing_page",
    "id": "color-contrast",
    "impact": "serious",
    "tags": [
      "cat.color",
      "wcag2aa",
      "wcag143",
      "ACT",
      "TTv5",
      "TT13.c"
    ],
    "description": "Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds",
    "help": "Elements must meet minimum color contrast ratio thresholds",
    "helpUrl": "https://dequeuniversity.com/rules/axe/4.7/color-contrast?application=axeAPI",
    "nodes": [
      {
        "any": [
          {
            "id": "color-contrast",
            "data": {
              "fgColor": "#dddddd",
              "bgColor": "#ffffff",
              "contrastRatio": 1.35,
              "fontSize": "19.2pt (25.632px)",
              "fontWeight": "bold",
              "messageKey": null,
              "expectedContrastRatio": "3:1"
            },
            "relatedNodes": [
              {
                "html": "<div id=\"toolbar-item-administration-tray\" data-toolbar-tray=\"toolbar-item-administration-tray\" class=\"toolbar-tray toolbar-tray-horizontal is-active\" data-offset-top=\"\">",
                "target": [
                  "#toolbar-item-administration-tray"
                ]
              }
            ],
            "impact": "serious",
            "message": "Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
          }
        ],
        "all": [],
        "none": [],
        "impact": "serious",
        "html": "<h3 class=\"toolbar-tray-name visually-hidden\">Administration menu</h3>",
        "target": [
          "nav[aria-label=\"Administration menu\"] > h3"
        ],
        "failureSummary": "Fix any of the following:
  Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
      }
    ]
  },
  {
    "route": "/resources/test-data-quibusdam",
    "id": "color-contrast",
    "impact": "serious",
    "tags": [
      "cat.color",
      "wcag2aa",
      "wcag143",
      "ACT",
      "TTv5",
      "TT13.c"
    ],
    "description": "Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds",
    "help": "Elements must meet minimum color contrast ratio thresholds",
    "helpUrl": "https://dequeuniversity.com/rules/axe/4.7/color-contrast?application=axeAPI",
    "nodes": [
      {
        "any": [
          {
            "id": "color-contrast",
            "data": {
              "fgColor": "#000000",
              "bgColor": "#353641",
              "contrastRatio": 1.75,
              "fontSize": "12.0pt (16px)",
              "fontWeight": "normal",
              "messageKey": null,
              "expectedContrastRatio": "4.5:1"
            },
            "relatedNodes": [
              {
                "html": "<div class=\"messages messages--status messages-list__item\" role=\"status\" aria-labelledby=\"status-450819032087579-title\" data-drupal-message-id=\"status-450819032087579\" data-drupal-message-type=\"status\">",
                "target": [
                  ".messages--status"
                ]
              }
            ],
            "impact": "serious",
            "message": "Element has insufficient color contrast of 1.75 (foreground color: #000000, background color: #353641, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1"
          }
        ],
        "all": [],
        "none": [],
        "impact": "serious",
        "html": "<div class=\"messages__content\">
      Step-by-Step <em class=\"placeholder\"><a href=\"/resources/test-data-quibusdam\" hreflang=\"en\">[Test Data] quibusdam</a></em> has been created.
    </div>",
        "target": [
          ".messages--status > .messages__content"
        ],
        "failureSummary": "Fix any of the following:
  Element has insufficient color contrast of 1.75 (foreground color: #000000, background color: #353641, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1"
      }
    ]
  }
]

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 18, 2024 15:05 Destroyed
Copy link

Checking composer.lock changes...

Copy link

The number of lines changed in composer.lock exceeds the acceptable threshold.

  • Lines changed: 236
  • Threshold: 200

This is a warning only. Please review the changes and ensure that they are acceptable.

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-voluptatem

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

@JakeBapple JakeBapple merged commit ced2d80 into main Nov 18, 2024
18 checks passed
@JakeBapple JakeBapple deleted the 19773-update-drupal-core-to-v1036 branch November 18, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update drupal core to v10.3.6
3 participants