-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-19773: update drupal core to v1038 #19873
Conversation
Checking composer.lock changes... |
The number of lines changed in composer.lock exceeds the acceptable threshold.
This is a warning only. Please review the changes and ensure that they are acceptable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Accessibility Violations Found: [
{
"route": "/user/5283",
"id": "color-contrast",
"impact": "serious",
"tags": [
"cat.color",
"wcag2aa",
"wcag143",
"ACT",
"TTv5",
"TT13.c"
],
"description": "Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds",
"help": "Elements must meet minimum color contrast ratio thresholds",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.7/color-contrast?application=axeAPI",
"nodes": [
{
"any": [
{
"id": "color-contrast",
"data": {
"fgColor": "#dddddd",
"bgColor": "#ffffff",
"contrastRatio": 1.35,
"fontSize": "19.2pt (25.632px)",
"fontWeight": "bold",
"messageKey": null,
"expectedContrastRatio": "3:1"
},
"relatedNodes": [
{
"html": "<div id=\"toolbar-item-administration-tray\" data-toolbar-tray=\"toolbar-item-administration-tray\" class=\"toolbar-tray toolbar-tray-horizontal is-active\" data-offset-top=\"\">",
"target": [
"#toolbar-item-administration-tray"
]
}
],
"impact": "serious",
"message": "Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
}
],
"all": [],
"none": [],
"impact": "serious",
"html": "<h3 class=\"toolbar-tray-name visually-hidden\">Administration menu</h3>",
"target": [
"nav[aria-label=\"Administration menu\"] > h3"
],
"failureSummary": "Fix any of the following:
Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
}
]
},
{
"route": "/node/add/basic_landing_page",
"id": "color-contrast",
"impact": "serious",
"tags": [
"cat.color",
"wcag2aa",
"wcag143",
"ACT",
"TTv5",
"TT13.c"
],
"description": "Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds",
"help": "Elements must meet minimum color contrast ratio thresholds",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.7/color-contrast?application=axeAPI",
"nodes": [
{
"any": [
{
"id": "color-contrast",
"data": {
"fgColor": "#dddddd",
"bgColor": "#ffffff",
"contrastRatio": 1.35,
"fontSize": "19.2pt (25.632px)",
"fontWeight": "bold",
"messageKey": null,
"expectedContrastRatio": "3:1"
},
"relatedNodes": [
{
"html": "<div id=\"toolbar-item-administration-tray\" data-toolbar-tray=\"toolbar-item-administration-tray\" class=\"toolbar-tray toolbar-tray-horizontal is-active\" data-offset-top=\"\">",
"target": [
"#toolbar-item-administration-tray"
]
}
],
"impact": "serious",
"message": "Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
}
],
"all": [],
"none": [],
"impact": "serious",
"html": "<h3 class=\"toolbar-tray-name visually-hidden\">Administration menu</h3>",
"target": [
"nav[aria-label=\"Administration menu\"] > h3"
],
"failureSummary": "Fix any of the following:
Element has insufficient color contrast of 1.35 (foreground color: #dddddd, background color: #ffffff, font size: 19.2pt (25.632px), font weight: bold). Expected contrast ratio of 3:1"
}
]
},
{
"route": "/resources/test-data-quibusdam",
"id": "color-contrast",
"impact": "serious",
"tags": [
"cat.color",
"wcag2aa",
"wcag143",
"ACT",
"TTv5",
"TT13.c"
],
"description": "Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds",
"help": "Elements must meet minimum color contrast ratio thresholds",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.7/color-contrast?application=axeAPI",
"nodes": [
{
"any": [
{
"id": "color-contrast",
"data": {
"fgColor": "#000000",
"bgColor": "#353641",
"contrastRatio": 1.75,
"fontSize": "12.0pt (16px)",
"fontWeight": "normal",
"messageKey": null,
"expectedContrastRatio": "4.5:1"
},
"relatedNodes": [
{
"html": "<div class=\"messages messages--status messages-list__item\" role=\"status\" aria-labelledby=\"status-450819032087579-title\" data-drupal-message-id=\"status-450819032087579\" data-drupal-message-type=\"status\">",
"target": [
".messages--status"
]
}
],
"impact": "serious",
"message": "Element has insufficient color contrast of 1.75 (foreground color: #000000, background color: #353641, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1"
}
],
"all": [],
"none": [],
"impact": "serious",
"html": "<div class=\"messages__content\">
Step-by-Step <em class=\"placeholder\"><a href=\"/resources/test-data-quibusdam\" hreflang=\"en\">[Test Data] quibusdam</a></em> has been created.
</div>",
"target": [
".messages--status > .messages__content"
],
"failureSummary": "Fix any of the following:
Element has insufficient color contrast of 1.75 (foreground color: #000000, background color: #353641, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1"
}
]
}
] |
Checking composer.lock changes... |
The number of lines changed in composer.lock exceeds the acceptable threshold.
This is a warning only. Please review the changes and ensure that they are acceptable. |
Cypress Accessibility Violations
|
Description
Relates to #19773
Testing done
Local testing and content generation
QA steps
What needs to be checked to prove this works?
Look at composer file to core-recommended and core-scaffold is up to 10.3.8
What needs to be checked to prove it didn't break any related things?
Spot check pages to make sure nothing is broken.
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing